linux-kernel - Re: [PATCH] xen/pciback: Make missing GSI non-fatal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8a046a27-c0bc-42ec-accb-17a36135563f@amd.com>
Date: Thu, 27 Feb 2025 10:19:53 -0500
From: Jason Andryuk <jason.andryuk@....com>
To: Jan Beulich <jbeulich@...e.com>
CC: <stable@...r.kernel.org>, <xen-devel@...ts.xenproject.org>,
	<linux-kernel@...r.kernel.org>, Juergen Gross <jgross@...e.com>, "Stefano
 Stabellini" <sstabellini@...nel.org>, Oleksandr Tyshchenko
	<oleksandr_tyshchenko@...m.com>, Jiqian Chen <Jiqian.Chen@....com>, Huang Rui
	<ray.huang@....com>
Subject: Re: [PATCH] xen/pciback: Make missing GSI non-fatal

On 2025-02-27 03:23, Jan Beulich wrote:
> On 26.02.2025 21:01, Jason Andryuk wrote:
> 
>> --- a/drivers/xen/acpi.c
>> +++ b/drivers/xen/acpi.c
>> @@ -101,7 +101,7 @@ int xen_acpi_get_gsi_info(struct pci_dev *dev,
>>   
>>   	pin = dev->pin;
>>   	if (!pin)
>> -		return -EINVAL;
>> +		return -ENOENT;
>>   
>>   	entry = acpi_pci_irq_lookup(dev, pin);
>>   	if (entry) {
> 
> While I can understand this change, ...
> 
>> @@ -116,7 +116,7 @@ int xen_acpi_get_gsi_info(struct pci_dev *dev,
>>   		gsi = -1;
>>   
>>   	if (gsi < 0)
>> -		return -EINVAL;
>> +		return -ENOENT;
>>   
>>   	*gsi_out = gsi;
>>   	*trigger_out = trigger;
> 
> ... I'd expect this needs to keep using an error code other than ENOENT.
> Aiui this path means the device has a pin-based interrupt, just that it's
> not configured correctly. In which case we'd better not allow the device
> to be handed to a guest. Unless there's logic in place (somewhere) to
> make sure it then would get to see a device without pin-based interrupt.

This is actually the case that fails for me.

05:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. 
RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller (rev 06)
         Interrupt: pin A routed to IRQ -2147483648

Interrupt Pin is 0x01, and Interrupt Line is 0xff

I'll have to check the existing code to see what it does.

Also, thanks for catching the commit message typos.

Regards,
Jason