linux-kernel - Re: [PATCH V9 2/7] interconnect: core: Add dynamic id allocation support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bv73i444oh4oakgqet7brkdpmusvpf4x5nbi7kgfvykts43roj@jnc5ps2sazeb>
Date: Thu, 27 Feb 2025 18:08:28 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Raviteja Laggyshetty <quic_rlaggysh@...cinc.com>
Cc: Georgi Djakov <djakov@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>, 
	Odelu Kukatla <quic_okukatla@...cinc.com>, Jeff Johnson <jeff.johnson@....qualcomm.com>, 
	Mike Tipton <mdtipton@...cinc.com>, Jagadeesh Kona <quic_jkona@...cinc.com>, 
	Sibi Sankar <quic_sibis@...cinc.com>, linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V9 2/7] interconnect: core: Add dynamic id allocation
 support

On Thu, Feb 27, 2025 at 03:52:08PM +0000, Raviteja Laggyshetty wrote:
> The current interconnect framework relies on static IDs for node
> creation and registration, which limits topologies with multiple
> instances of the same interconnect provider. To address this, update
> the interconnect framework APIs icc_node_create() and icc_link_create()
> APIs to dynamically allocate IDs for interconnect nodes during creation.
> This change removes the dependency on static IDs, allowing multiple
> instances of the same hardware, such as EPSS L3.
> 
> Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@...cinc.com>
> ---
>  drivers/interconnect/core.c  | 13 ++++++++++++-
>  include/linux/interconnect.h |  3 +++
>  2 files changed, 15 insertions(+), 1 deletion(-)
> 



> diff --git a/include/linux/interconnect.h b/include/linux/interconnect.h
> index 97ac253df62c..8b0f892aaed2 100644
> --- a/include/linux/interconnect.h
> +++ b/include/linux/interconnect.h
> @@ -20,6 +20,9 @@
>  #define Mbps_to_icc(x)	((x) * 1000 / 8)
>  #define Gbps_to_icc(x)	((x) * 1000 * 1000 / 8)
>  
> +/* macro to indicate dynamic id allocation */
> +#define ALLOC_DYN_ID	-1

Nit: ICC_ALLOC_DYN_ID

With that fixed,

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>

> +
>  struct icc_path;
>  struct device;
>  
> -- 
> 2.43.0
> 

-- 
With best wishes
Dmitry