linux-kernel - Re: [PATCH net] net: ti: icss-iep: Reject perout generation request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <542018d4-ded1-40c6-9a97-d3789877b771@linux.dev>
Date: Thu, 27 Feb 2025 16:06:17 +0000
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Meghana Malladi <m-malladi@...com>, vigneshr@...com,
 javier.carrasco.cruz@...il.com, jacob.e.keller@...el.com,
 diogo.ivo@...mens.com, horms@...nel.org, richardcochran@...il.com,
 pabeni@...hat.com, kuba@...nel.org, edumazet@...gle.com,
 davem@...emloft.net, andrew+netdev@...n.ch
Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, srk@...com,
 Roger Quadros <rogerq@...nel.org>, danishanwar@...com
Subject: Re: [PATCH net] net: ti: icss-iep: Reject perout generation request

On 27/02/2025 09:24, Meghana Malladi wrote:
> IEP driver supports both perout and pps signal generation
> but perout feature is faulty with half-cooked support
> due to some missing configuration. Remove perout
> support from the driver and reject perout requests with
> "not supported" error code.
> 
> Fixes: c1e0230eeaab2 ("net: ti: icss-iep: Add IEP driver")
> Signed-off-by: Meghana Malladi <m-malladi@...com>
> ---
> 
> This patch is a bug fix to disable/remove a faulty feature, which will be
> enabled separately as a feature addition to net-next, as suggested by
> Jakub Kicinski and Jacob Keller:
> https://lore.kernel.org/all/20250220172410.025b96d6@kernel.org/
> 
>   drivers/net/ethernet/ti/icssg/icss_iep.c | 21 +--------------------
>   1 file changed, 1 insertion(+), 20 deletions(-)
> 
> diff --git a/drivers/net/ethernet/ti/icssg/icss_iep.c b/drivers/net/ethernet/ti/icssg/icss_iep.c
> index 768578c0d958..d59c1744840a 100644
> --- a/drivers/net/ethernet/ti/icssg/icss_iep.c
> +++ b/drivers/net/ethernet/ti/icssg/icss_iep.c
> @@ -474,26 +474,7 @@ static int icss_iep_perout_enable_hw(struct icss_iep *iep,
>   static int icss_iep_perout_enable(struct icss_iep *iep,
>   				  struct ptp_perout_request *req, int on)
>   {
> -	int ret = 0;
> -
> -	mutex_lock(&iep->ptp_clk_mutex);
> -
> -	if (iep->pps_enabled) {
> -		ret = -EBUSY;
> -		goto exit;
> -	}
> -
> -	if (iep->perout_enabled == !!on)
> -		goto exit;
> -
> -	ret = icss_iep_perout_enable_hw(iep, req, on);
> -	if (!ret)
> -		iep->perout_enabled = !!on;
> -
> -exit:
> -	mutex_unlock(&iep->ptp_clk_mutex);
> -
> -	return ret;
> +	return -EOPNOTSUPP;
>   }
>   
>   static void icss_iep_cap_cmp_work(struct work_struct *work)
> 
> base-commit: 29b036be1b0bfcfc958380d5931325997fddf08a

LGTM. It maybe cleaner to remove PTP_CLK_REQ_PEROUT in
icss_iep_ptp_enable as well, but if the idea is to bring the feature
back, then it should be good enough.

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>