linux-kernel - Re: [PATCH] security: keys: Make sysctl table const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHC9VhQfC3kXt39qBS3NEHtGNqNhD1SpJ103_kUtOCi0HTMDHg@mail.gmail.com>
Date: Thu, 27 Feb 2025 11:45:09 -0500
From: Paul Moore <paul@...l-moore.com>
To: Ricardo B. Marlière <rbm@...e.com>
Cc: "Ricardo B. Marliere" <ricardo@...liere.net>, David Howells <dhowells@...hat.com>, 
	Jarkko Sakkinen <jarkko@...nel.org>, James Morris <jmorris@...ei.org>, 
	"Serge E. Hallyn" <serge@...lyn.com>, keyrings@...r.kernel.org, 
	linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Thomas Weißschuh <linux@...ssschuh.net>
Subject: Re: [PATCH] security: keys: Make sysctl table const

On Thu, Feb 27, 2025 at 5:47 AM Ricardo B. Marlière <rbm@...e.com> wrote:
> On Wed Feb 26, 2025 at 9:21 PM -03, Paul Moore wrote:
> > On Thu, Jan 23, 2025 at 2:50 PM Ricardo B. Marliere
> > <ricardo@...liere.net> wrote:
> >>
> >> Since commit 7abc9b53bd51 ("sysctl: allow registration of const struct
> >> ctl_table"), the sysctl registration API allows for struct ctl_table to be
> >> in read-only memory. Move key_sysctls to be declared at build time, instead
> >> of having to be dynamically allocated at boot time.
> >>
> >> Cc: Thomas Weißschuh <linux@...ssschuh.net>
> >> Suggested-by: Thomas Weißschuh <linux@...ssschuh.net>
> >> Signed-off-by: Ricardo B. Marliere <rbm@...e.com>
> >> ---
> >>  security/keys/sysctl.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Looks fine to me.  David or Jarkko, this looks like something for the
> > keys tree, yes?
> >
> > Reviewed-by: Paul Moore <paul@...l-moore.com>
>
> Thank you for the review, but I believe this has been done here:
>
> https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1751f872cc97f992ed5c4c72c55588db1f0021e1

Even better :)  Thanks for the update Ricardo.

-- 
paul-moore.com