linux-kernel - Re: [PATCH] security: keys: Make sysctl table const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8JqHy6IDOR_X-RJ@kernel.org>
Date: Sat, 1 Mar 2025 03:59:59 +0200
From: Jarkko Sakkinen <jarkko@...nel.org>
To: Paul Moore <paul@...l-moore.com>
Cc: "Ricardo B. Marliere" <ricardo@...liere.net>,
	David Howells <dhowells@...hat.com>,
	James Morris <jmorris@...ei.org>,
	"Serge E. Hallyn" <serge@...lyn.com>, keyrings@...r.kernel.org,
	linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org,
	Thomas Weißschuh <linux@...ssschuh.net>,
	"Ricardo B. Marliere" <rbm@...e.com>
Subject: Re: [PATCH] security: keys: Make sysctl table const

On Wed, Feb 26, 2025 at 07:21:39PM -0500, Paul Moore wrote:
> On Thu, Jan 23, 2025 at 2:50 PM Ricardo B. Marliere
> <ricardo@...liere.net> wrote:
> >
> > Since commit 7abc9b53bd51 ("sysctl: allow registration of const struct
> > ctl_table"), the sysctl registration API allows for struct ctl_table to be
> > in read-only memory. Move key_sysctls to be declared at build time, instead
> > of having to be dynamically allocated at boot time.
> >
> > Cc: Thomas Weißschuh <linux@...ssschuh.net>
> > Suggested-by: Thomas Weißschuh <linux@...ssschuh.net>
> > Signed-off-by: Ricardo B. Marliere <rbm@...e.com>
> > ---
> >  security/keys/sysctl.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Looks fine to me.  David or Jarkko, this looks like something for the
> keys tree, yes?
> 
> Reviewed-by: Paul Moore <paul@...l-moore.com>

I can pick this after back from holiday on next week.

Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

BR, Jarkko