linux-kernel - Re: [PATCH] clk: rockchip: Add reset lookup table for RK3528

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8CzMNI_1CjUgSrl@pie.lan>
Date: Thu, 27 Feb 2025 18:47:12 +0000
From: Yao Zi <ziyao@...root.org>
To: Jonas Karlman <jonas@...boo.se>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>, Heiko Stuebner <heiko@...ech.de>
Cc: linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH] clk: rockchip: Add reset lookup table for RK3528

On Thu, Feb 27, 2025 at 05:52:57PM +0000, Jonas Karlman wrote:
> In the commit 5d0eb375e685 ("clk: rockchip: Add clock controller driver
> for RK3528 SoC") only the dt-binding header was added for the reset
> controller for the RK3528 SoC.
> 
> Add a reset lookup table generated from the SRST symbols used by vendor
> linux-6.1-stan-rkr5 kernel to complete support for the reset controller.
> 

Thanks for completing the reset part! The patch looks good to me, but

> Fixes: 5d0eb375e685 ("clk: rockchip: Add clock controller driver for RK3528 SoC")

I wonder whether it deserves a Fix tag: to me it's more like a new
feature. Please correct me if I'm wrong.

> Signed-off-by: Jonas Karlman <jonas@...boo.se>
> ---
>  drivers/clk/rockchip/Makefile     |   2 +-
>  drivers/clk/rockchip/clk-rk3528.c |   2 +
>  drivers/clk/rockchip/clk.h        |   1 +
>  drivers/clk/rockchip/rst-rk3528.c | 306 ++++++++++++++++++++++++++++++
>  4 files changed, 310 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/clk/rockchip/rst-rk3528.c
> 

Thanks,
Yao Zi