linux-kernel - Re: [PATCH] clk: rockchip: Add reset lookup table for RK3528

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3022099.BaHzMo0RvP@diego>
Date: Thu, 27 Feb 2025 20:20:52 +0100
From: Heiko Stübner <heiko@...ech.de>
To: Jonas Karlman <jonas@...boo.se>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>,
 Yao Zi <ziyao@...root.org>
Cc: linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH] clk: rockchip: Add reset lookup table for RK3528

Am Donnerstag, 27. Februar 2025, 19:47:12 MEZ schrieb Yao Zi:
> On Thu, Feb 27, 2025 at 05:52:57PM +0000, Jonas Karlman wrote:
> > In the commit 5d0eb375e685 ("clk: rockchip: Add clock controller driver
> > for RK3528 SoC") only the dt-binding header was added for the reset
> > controller for the RK3528 SoC.
> > 
> > Add a reset lookup table generated from the SRST symbols used by vendor
> > linux-6.1-stan-rkr5 kernel to complete support for the reset controller.
> > 
> 
> Thanks for completing the reset part! The patch looks good to me, but
> 
> > Fixes: 5d0eb375e685 ("clk: rockchip: Add clock controller driver for RK3528 SoC")
> 
> I wonder whether it deserves a Fix tag: to me it's more like a new
> feature. Please correct me if I'm wrong.

while one can see both sides, I agree that the Fixes is unnecessary in
this case. I've applied the clock controller mere hours ago and it was
not broken, just missing functionality ;-)

I've applied the patch now, and removed the Fixes line.


Heiko