linux-kernel - Re: [PATCH RFC v1 01/11] x86/fpu/xstate: Simplify print_xstate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8c81e0f1-4fae-41c7-a0d5-c27076a122f3@intel.com>
Date: Thu, 27 Feb 2025 10:51:57 -0800
From: Dave Hansen <dave.hansen@...el.com>
To: "Chang S. Bae" <chang.seok.bae@...el.com>, linux-kernel@...r.kernel.org
Cc: x86@...nel.org, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
 dave.hansen@...ux.intel.com
Subject: Re: [PATCH RFC v1 01/11] x86/fpu/xstate: Simplify
 print_xstate_features()

On 2/27/25 10:44, Chang S. Bae wrote:
> I find it difficult to justify using separate lines for printing when
> they can be efficiently grouped under a simple for-loop. While this
> cleanup isn't directly related to APX, it felt like a necessary
> improvement, especially when new xstates are introduced.

Yeah, this approach made some sense when the string was defined there too:

        print_xstate_feature(XSTATE_OPMASK,     "AVX-512 opmask");
        print_xstate_feature(XSTATE_ZMM_Hi256,  "AVX-512 Hi256");
	...

But it doesn't now that the strings are in a separate structure.

Reviewed-by: Dave Hansen <dave.hansen@...ux.intel.com>