linux-kernel - Re: [PATCH RFC v1 01/11] x86/fpu/xstate: Simplify print_xstate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8C0UYHV9q10bKoF@gmail.com>
Date: Thu, 27 Feb 2025 19:52:01 +0100
From: Ingo Molnar <mingo@...nel.org>
To: "Chang S. Bae" <chang.seok.bae@...el.com>
Cc: linux-kernel@...r.kernel.org, x86@...nel.org, tglx@...utronix.de,
	mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com
Subject: Re: [PATCH RFC v1 01/11] x86/fpu/xstate: Simplify
 print_xstate_features()


* Chang S. Bae <chang.seok.bae@...el.com> wrote:

> print_xstate_features() currently invokes print_xstate_feature() multiple
> times on separate lines, which can be simplified in a loop.
> 
> print_xstate_feature() already checks the feature's enabled status and is
> only called within print_xstate_features(). Inline print_xstate_feature()
> and iterate over features in a loop to streamline the enabling message.
> 
> No functional changes.
> 
> Signed-off-by: Chang S. Bae <chang.seok.bae@...el.com>
> ---
> I find it difficult to justify using separate lines for printing when
> they can be efficiently grouped under a simple for-loop. While this
> cleanup isn't directly related to APX, it felt like a necessary
> improvement, especially when new xstates are introduced.

Agreed, and I've picked up this simplification independently in 
tip:x86/fpu.

Thanks,

	Ingo