linux-kernel - Re: [PATCH v3 15/20] ASoC: tas2764: Enable main IRQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHgNfTx_kMj=rsd4nUCiX_PvgC4GX3DsPDwXHdEyEeLMbDFccw@mail.gmail.com>
Date: Fri, 28 Feb 2025 07:58:33 +1000
From: James Calligeros <jcalligeros99@...il.com>
To: Mark Brown <broonie@...nel.org>
Cc: Liam Girdwood <lgirdwood@...il.com>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, 
	Shenghao Ding <shenghao-ding@...com>, Kevin Lu <kevin-lu@...com>, Baojun Xu <baojun.xu@...com>, 
	Dan Murphy <dmurphy@...com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Shi Fu <shifu0704@...ndersoft.com>, Jean Delvare <jdelvare@...e.com>, 
	Guenter Roeck <linux@...ck-us.net>, Alyssa Rosenzweig <alyssa@...enzweig.io>, 
	Martin Povišer <povik+lin@...ebit.org>, 
	Hector Martin <marcan@...can.st>, linux-sound@...r.kernel.org, 
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, 
	asahi@...ts.linux.dev, linux-hwmon@...r.kernel.org, 
	Neal Gompa <neal@...pa.dev>
Subject: Re: [PATCH v3 15/20] ASoC: tas2764: Enable main IRQs

On Fri, Feb 28, 2025 at 2:23 AM Mark Brown <broonie@...nel.org> wrote:
>
> On Thu, Feb 27, 2025 at 10:07:42PM +1000, James Calligeros wrote:
> > From: Hector Martin <marcan@...can.st>
> >
> > IRQ handling was added in commit dae191fb957f ("ASoC: tas2764: Add IRQ
> > handling") however that same commit masks all interrupts coming from
> > the chip. Unmask the "main" interrupts so that we can see and
> > deal with a number of errors including clock, voltage, and current.
>
> Shouldn't this also be a fix?

I don't think so. The referenced commit only says that it adds an IRQ handler.
I don't think this commit is actually "fixing" anything - it's just
enabling previously
masked interrupts.

Happy to move things around if you disagree.

James