linux-kernel - Re: [PATCH v3 15/20] ASoC: tas2764: Enable main IRQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba20e709-517b-441a-8f89-37518d0a1d4f@sirena.org.uk>
Date: Fri, 28 Feb 2025 13:53:56 +0000
From: Mark Brown <broonie@...nel.org>
To: James Calligeros <jcalligeros99@...il.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>, Shenghao Ding <shenghao-ding@...com>,
	Kevin Lu <kevin-lu@...com>, Baojun Xu <baojun.xu@...com>,
	Dan Murphy <dmurphy@...com>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Shi Fu <shifu0704@...ndersoft.com>,
	Jean Delvare <jdelvare@...e.com>,
	Guenter Roeck <linux@...ck-us.net>,
	Alyssa Rosenzweig <alyssa@...enzweig.io>,
	Martin Povišer <povik+lin@...ebit.org>,
	Hector Martin <marcan@...can.st>, linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	asahi@...ts.linux.dev, linux-hwmon@...r.kernel.org,
	Neal Gompa <neal@...pa.dev>
Subject: Re: [PATCH v3 15/20] ASoC: tas2764: Enable main IRQs

On Fri, Feb 28, 2025 at 07:58:33AM +1000, James Calligeros wrote:
> On Fri, Feb 28, 2025 at 2:23 AM Mark Brown <broonie@...nel.org> wrote:
> > On Thu, Feb 27, 2025 at 10:07:42PM +1000, James Calligeros wrote:

> > > IRQ handling was added in commit dae191fb957f ("ASoC: tas2764: Add IRQ
> > > handling") however that same commit masks all interrupts coming from
> > > the chip. Unmask the "main" interrupts so that we can see and
> > > deal with a number of errors including clock, voltage, and current.

> > Shouldn't this also be a fix?

> I don't think so. The referenced commit only says that it adds an IRQ handler.
> I don't think this commit is actually "fixing" anything - it's just
> enabling previously
> masked interrupts.

I think the expectation would be that when the interrupt handler was
added it would've been possible for it to fire.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)