linux-kernel - Re: [PATCH v7 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PN3PR01MB9597D311510957F1FDABE143B8CD2@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>
Date: Thu, 27 Feb 2025 09:42:00 +0000
From: Aditya Garg <gargaditya08@...e.com>
To: Thomas Zimmermann <tzimmermann@...e.de>
CC: "maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
	"mripard@...nel.org" <mripard@...nel.org>, "airlied@...il.com"
	<airlied@...il.com>, "simona@...ll.ch" <simona@...ll.ch>,
	"andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>,
	Kerem Karabay <kekrby@...il.com>, Atharva Tiwari <evepolonium@...il.com>,
	Aun-Ali Zaidi <admin@...eit.net>, Linux Kernel Mailing List
	<linux-kernel@...r.kernel.org>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH v7 2/2] drm/tiny: add driver for Apple Touch Bars in x86
 Macs



> On 27 Feb 2025, at 3:04 PM, Thomas Zimmermann <tzimmermann@...e.de> wrote:
> 
> Hi
> 
>> Am 26.02.25 um 17:04 schrieb Aditya Garg:
>> From: Kerem Karabay <kekrby@...il.com>
>> 
>> The Touch Bars found on x86 Macs support two USB configurations: one
>> where the device presents itself as a HID keyboard and can display
>> predefined sets of keys, and one where the operating system has full
>> control over what is displayed.
>> 
>> This commit adds support for the display functionality of the second
>> configuration. Functionality for the first configuration has been
>> merged in the HID tree.
>> 
>> Note that this driver has only been tested on T2 Macs, and only includes
>> the USB device ID for these devices. Testing on T1 Macs would be
>> appreciated.
>> 
>> Credit goes to Ben (Bingxing) Wang on GitHub for reverse engineering
>> most of the protocol.
>> 
>> Also, as requested by Andy, I would like to clarify the use of __packed
>> structs in this driver:
>> 
>> - All the packed structs are aligned except for appletbdrm_msg_information.
>> - We have to pack appletbdrm_msg_information since it is requirement of
>>   the protocol.
>> - We compared binaries compiled by keeping the rest structs __packed and
>>   not __packed using bloat-o-meter, and __packed was not affecting code
>>   generation.
>> - To maintain consistency, rest structs have been kept __packed.
>> 
>> I would also like to point out that since the driver was reverse-engineered
>> the actual data types of the protocol might be different, including, but
>> not limited to, endianness.
>> 
>> Link: https://github.com/imbushuo/DFRDisplayKm
>> Signed-off-by: Kerem Karabay <kekrby@...il.com>
>> Co-developed-by: Atharva Tiwari <evepolonium@...il.com>
>> Signed-off-by: Atharva Tiwari <evepolonium@...il.com>
>> Co-developed-by: Aditya Garg <gargaditya08@...e.com>
>> Signed-off-by: Aditya Garg <gargaditya08@...e.com>
>> Signed-off-by: Aun-Ali Zaidi <admin@...eit.net>
> 
> Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>
> 
> Thanks for the effort. As far as I'm concerned, this driver looks good. If no further comments come in, I can add it to the DRM tree in a few days.

Thanks a lot Thomas, as well as Andy for reviewing the driver and making it better!