linux-kernel - Re: [PATCH v2] rapidio: fix an API misues when rio_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <910d7ee5-87e4-40fd-b1f9-c1d99e4df304@stanley.mountain>
Date: Thu, 27 Feb 2025 12:59:12 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Haoxiang Li <haoxiang_li2024@....com>
Cc: mporter@...nel.crashing.org, alex.bou9@...il.com,
	akpm@...ux-foundation.org, error27@...il.com,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v2] rapidio: fix an API misues when rio_add_net() fails

On Thu, Feb 27, 2025 at 03:34:09PM +0800, Haoxiang Li wrote:
> rio_add_net() calls device_register() and fails when device_register()
> fails. Thus, put_device() should be used rather than kfree().
> Add "mport->net = NULL;" to avoid a use after free issue.
> 
> Fixes: e8de370188d0 ("rapidio: add mport char device driver")
> Cc: stable@...r.kernel.org
> Signed-off-by: Haoxiang Li <haoxiang_li2024@....com>
> ---
> Changes in v2:
> - Add "mport->net = NULL;" to avoid a use after free issue. Thanks, Dan!

Thank you!

Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>

regards,
dan carpenter