linux-kernel - Re: [PATCH][next] scripts/sorttable: Fix resource leak on file pointer fp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ce34b982-490e-44dc-8071-c04d4fbcb0f1@gmail.com>
Date: Thu, 27 Feb 2025 09:58:58 +0000
From: "Colin King (gmail)" <colin.i.king@...il.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Steven Rostedt <rostedt@...dmis.org>,
 Catalin Marinas <catalin.marinas@....com>, kernel-janitors@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] scripts/sorttable: Fix resource leak on file
 pointer fp

On 27/02/2025 09:57, Dan Carpenter wrote:
> On Wed, Feb 26, 2025 at 10:49:34PM +0000, Colin Ian King wrote:
>> There is a resource leak on fp on an error return path in function
>> parse_symbols that causes a resource leak. Fix this by adding in
>> the missing fclose.
>>
>> Fixes: ef378c3b8233 ("scripts/sorttable: Zero out weak functions in mcount_loc table")
>> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> 
> This is in scripts/ so it doesn't really matter.  We're going to exit
> and release everything immediately either way.

Ack. Won't fix these issues in scripts in future.

> 
> regards,
> dan carpenter
> 


Download attachment "OpenPGP_0x68C287DFC6A80226.asc" of type "application/pgp-keys" (4825 bytes)

Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (841 bytes)