linux-kernel - Re: [PATCH 1/7] MIPS: dec: Declare which

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8A3sucKlB5i0zd9@alpha.franken.de>
Date: Thu, 27 Feb 2025 11:00:18 +0100
From: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To: WangYuli <wangyuli@...ontech.com>
Cc: chenlinxuan@...ontech.com, guanwentao@...ontech.com,
	linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org,
	macro@...am.me.uk, niecheng1@...ontech.com, zhanjun@...ontech.com
Subject: Re: [PATCH 1/7] MIPS: dec: Declare which_prom() as static

On Tue, Feb 18, 2025 at 08:54:31PM +0800, WangYuli wrote:
> Declare which_prom() as static to suppress gcc compiler warning that
> 'missing-prototypes'. This function is not intended to be called
> from other parts.
> 
> Fix follow error with gcc-14 when -Werror:
> 
> arch/mips/dec/prom/init.c:45:13: error: no previous prototype for ‘which_prom’ [-Werror=missing-prototypes]
>    45 | void __init which_prom(s32 magic, s32 *prom_vec)
>       |             ^~~~~~~~~~
> cc1: all warnings being treated as errors
> make[6]: *** [scripts/Makefile.build:207: arch/mips/dec/prom/init.o] Error 1
> make[5]: *** [scripts/Makefile.build:465: arch/mips/dec/prom] Error 2
> make[5]: *** Waiting for unfinished jobs....
> 
> Signed-off-by: WangYuli <wangyuli@...ontech.com>
> ---
>  arch/mips/dec/prom/init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/dec/prom/init.c b/arch/mips/dec/prom/init.c
> index cb12eb211a49..8d74d7d6c05b 100644
> --- a/arch/mips/dec/prom/init.c
> +++ b/arch/mips/dec/prom/init.c
> @@ -42,7 +42,7 @@ int (*__pmax_close)(int);
>   * Detect which PROM the DECSTATION has, and set the callback vectors
>   * appropriately.
>   */
> -void __init which_prom(s32 magic, s32 *prom_vec)
> +static void __init which_prom(s32 magic, s32 *prom_vec)
>  {
>  	/*
>  	 * No sign of the REX PROM's magic number means we assume a non-REX
> -- 
> 2.47.2

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]