linux-kernel - Re: [PATCH 3/7] MIPS: cevt-ds1287: Add missing ds1287.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8A3wdxvNU0aw9ys@alpha.franken.de>
Date: Thu, 27 Feb 2025 11:00:33 +0100
From: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To: WangYuli <wangyuli@...ontech.com>
Cc: chenlinxuan@...ontech.com, guanwentao@...ontech.com,
	linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org,
	macro@...am.me.uk, niecheng1@...ontech.com, zhanjun@...ontech.com
Subject: Re: [PATCH 3/7] MIPS: cevt-ds1287: Add missing ds1287.h include

On Tue, Feb 18, 2025 at 08:57:23PM +0800, WangYuli wrote:
> Address the issue of cevt-ds1287.c not including the ds1287.h header
> file.
> 
> Fix follow errors with gcc-14 when -Werror:
> 
> arch/mips/kernel/cevt-ds1287.c:15:5: error: no previous prototype for ‘ds1287_timer_state’ [-Werror=missing-prototypes]
>    15 | int ds1287_timer_state(void)
>       |     ^~~~~~~~~~~~~~~~~~
> arch/mips/kernel/cevt-ds1287.c:20:5: error: no previous prototype for ‘ds1287_set_base_clock’ [-Werror=missing-prototypes]
>    20 | int ds1287_set_base_clock(unsigned int hz)
>       |     ^~~~~~~~~~~~~~~~~~~~~
> arch/mips/kernel/cevt-ds1287.c:103:12: error: no previous prototype for ‘ds1287_clockevent_init’ [-Werror=missing-prototypes]
>   103 | int __init ds1287_clockevent_init(int irq)
>       |            ^~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> make[7]: *** [scripts/Makefile.build:207: arch/mips/kernel/cevt-ds1287.o] Error 1
> make[7]: *** Waiting for unfinished jobs....
> make[6]: *** [scripts/Makefile.build:465: arch/mips/kernel] Error 2
> make[6]: *** Waiting for unfinished jobs....
> 
> Signed-off-by: WangYuli <wangyuli@...ontech.com>
> ---
>  arch/mips/kernel/cevt-ds1287.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/mips/kernel/cevt-ds1287.c b/arch/mips/kernel/cevt-ds1287.c
> index 9a47fbcd4638..de64d6bb7ba3 100644
> --- a/arch/mips/kernel/cevt-ds1287.c
> +++ b/arch/mips/kernel/cevt-ds1287.c
> @@ -10,6 +10,7 @@
>  #include <linux/mc146818rtc.h>
>  #include <linux/irq.h>
>  
> +#include <asm/ds1287.h>
>  #include <asm/time.h>
>  
>  int ds1287_timer_state(void)
> -- 
> 2.47.2

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]