[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID:
<OSAPR01MB27721284D1D4AD91C7E15621FFCD2@OSAPR01MB2772.jpnprd01.prod.outlook.com>
Date: Thu, 27 Feb 2025 11:06:36 +0000
From: John Madieu <john.madieu.xa@...renesas.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
CC: Rob Herring <robh@...nel.org>, "mturquette@...libre.com"
<mturquette@...libre.com>, "magnus.damm@...il.com" <magnus.damm@...il.com>,
"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "rui.zhang@...el.com"
<rui.zhang@...el.com>, "daniel.lezcano@...aro.org"
<daniel.lezcano@...aro.org>, "sboyd@...nel.org" <sboyd@...nel.org>,
"geert+renesas@...der.be" <geert+renesas@...der.be>, "lukasz.luba@....com"
<lukasz.luba@....com>, "rafael@...nel.org" <rafael@...nel.org>,
"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>, Biju Das
<biju.das.jz@...renesas.com>, Claudiu Beznea
<claudiu.beznea.uj@...renesas.com>, "conor+dt@...nel.org"
<conor+dt@...nel.org>, "devicetree@...r.kernel.org"
<devicetree@...r.kernel.org>, "john.madieu@...il.com"
<john.madieu@...il.com>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, "linux-renesas-soc@...r.kernel.org"
<linux-renesas-soc@...r.kernel.org>, "linux-clk@...r.kernel.org"
<linux-clk@...r.kernel.org>
Subject: RE: [PATCH 3/7] dt-bindings: thermal: r9a09g047-tsu: Document the TSU
unit
Hi Geert,
Thanks for your review.
> -----Original Message-----
> From: Geert Uytterhoeven <geert@...ux-m68k.org>
> Sent: Thursday, February 27, 2025 10:11 AM
> Subject: Re: [PATCH 3/7] dt-bindings: thermal: r9a09g047-tsu: Document the
> TSU unit
>
> Hi John,
>
> On Wed, 26 Feb 2025 at 16:40, John Madieu <john.madieu.xa@...renesas.com>
> wrote:
> > > > + interrupts:
> > > > + description: |
> > > > + Interrupt specifiers for the TSU:
> > > > + - S12TSUADI1: Conversion complete interrupt signal (pulse)
> > > > + - S12TSUADCMPI1: Comparison result interrupt signal (level)
> > > > +
> > > > + interrupt-names:
> > > > + items:
> > > > + - const: S12TSUADI1
> > > > + - const: S12TSUADCMPI1
> > >
>
> These are the names from the point of view of the interrupt controller
> (Section 4.6 Interrupt Controller Table 4.6-24 List of Input Events).
> The silly "1" suffix does seem have a meaning here, as S12TSUADI0 seems to
> be a DMAC request signal...
>
> For the TSU bindings, we want the names from the point of view of the TSU.
> Section 7.11 Temperature Sensor Unit (TSU) Table 7.11-3 List of Internal
> I/O Pins lists:
> - S12TSUADI: Conversion complete interrupt signal (pulse)
> - S12TSUADCMPI: Comparison result interrupt signal (level)
>
> So I'd go for "adi" and "adcmpi".
All right. I'll go for it in v2.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
> -- Linus Torvalds
Regards,
John
Powered by blists - more mailing lists