| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250227120525.66c348a0@foz.lan> Date: Thu, 27 Feb 2025 12:05:25 +0100 From: Mauro Carvalho Chehab <mchehab+huawei@...nel.org> To: Igor Mammedov <imammedo@...hat.com> Cc: "Michael S . Tsirkin" <mst@...hat.com>, Jonathan Cameron <Jonathan.Cameron@...wei.com>, Shiju Jose <shiju.jose@...wei.com>, qemu-arm@...gnu.org, qemu-devel@...gnu.org, Philippe Mathieu-Daudé <philmd@...aro.org>, Ani Sinha <anisinha@...hat.com>, Cleber Rosa <crosa@...hat.com>, Dongjiu Geng <gengdongjiu1@...il.com>, Eduardo Habkost <eduardo@...kost.net>, Eric Blake <eblake@...hat.com>, John Snow <jsnow@...hat.com>, Marcel Apfelbaum <marcel.apfelbaum@...il.com>, Markus Armbruster <armbru@...hat.com>, Michael Roth <michael.roth@....com>, Paolo Bonzini <pbonzini@...hat.com>, Peter Maydell <peter.maydell@...aro.org>, Shannon Zhao <shannon.zhaosl@...il.com>, Yanan Wang <wangyanan55@...wei.com>, Zhao Liu <zhao1.liu@...el.com>, kvm@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v4 00/14] Change ghes to use HEST-based offsets and add support for error inject Em Thu, 27 Feb 2025 10:54:54 +0100 Igor Mammedov <imammedo@...hat.com> escreveu: > On Fri, 21 Feb 2025 15:35:09 +0100 > Mauro Carvalho Chehab <mchehab+huawei@...nel.org> wrote: > > > Now that the ghes preparation patches were merged, let's add support > > for error injection. > > > > On this series, the first 6 patches chang to the math used to calculate offsets at HEST > > table and hardware_error firmware file, together with its migration code. Migration tested > > with both latest QEMU released kernel and upstream, on both directions. > > > > The next patches add a new QAPI to allow injecting GHESv2 errors, and a script using such QAPI > > to inject ARM Processor Error records. > > > > --- > > v4: > > - added an extra comment for AcpiGhesState structure; > > - patches reordered; > > - no functional changes, just code shift between the patches in this series. > > > > v3: > > - addressed more nits; > > - hest_add_le now points to the beginning of HEST table; > > - removed HEST from tests/data/acpi; > > - added an extra patch to not use fw_cfg with virt-10.0 for hw_error_le > > > > v2: > > - address some nits; > > - improved ags cleanup patch and removed ags.present field; > > - added some missing le*_to_cpu() calls; > > - update date at copyright for new files to 2024-2025; > > - qmp command changed to: inject-ghes-v2-error ans since updated to 10.0; > > - added HEST and DSDT tables after the changes to make check target happy. > > (two patches: first one whitelisting such tables; second one removing from > > whitelist and updating/adding such tables to tests/data/acpi) > > > > > > > > Mauro Carvalho Chehab (14): > > acpi/ghes: prepare to change the way HEST offsets are calculated > > acpi/ghes: add a firmware file with HEST address > > acpi/ghes: Use HEST table offsets when preparing GHES records > > acpi/ghes: don't hard-code the number of sources for HEST table > > acpi/ghes: add a notifier to notify when error data is ready > > acpi/ghes: create an ancillary acpi_ghes_get_state() function > > acpi/generic_event_device: Update GHES migration to cover hest addr > > acpi/generic_event_device: add logic to detect if HEST addr is > > available > > acpi/generic_event_device: add an APEI error device > > tests/acpi: virt: allow acpi table changes for a new table: HEST > > arm/virt: Wire up a GED error device for ACPI / GHES > > tests/acpi: virt: add a HEST table to aarch64 virt and update DSDT > > qapi/acpi-hest: add an interface to do generic CPER error injection > > scripts/ghes_inject: add a script to generate GHES error inject > > > > MAINTAINERS | 10 + > > hw/acpi/Kconfig | 5 + > > hw/acpi/aml-build.c | 10 + > > hw/acpi/generic_event_device.c | 43 ++ > > hw/acpi/ghes-stub.c | 7 +- > > hw/acpi/ghes.c | 231 ++++-- > > hw/acpi/ghes_cper.c | 38 + > > hw/acpi/ghes_cper_stub.c | 19 + > > hw/acpi/meson.build | 2 + > > hw/arm/virt-acpi-build.c | 37 +- > > hw/arm/virt.c | 19 +- > > hw/core/machine.c | 2 + > > include/hw/acpi/acpi_dev_interface.h | 1 + > > include/hw/acpi/aml-build.h | 2 + > > include/hw/acpi/generic_event_device.h | 1 + > > include/hw/acpi/ghes.h | 54 +- > > include/hw/arm/virt.h | 2 + > > qapi/acpi-hest.json | 35 + > > qapi/meson.build | 1 + > > qapi/qapi-schema.json | 1 + > > scripts/arm_processor_error.py | 476 ++++++++++++ > > scripts/ghes_inject.py | 51 ++ > > scripts/qmp_helper.py | 702 ++++++++++++++++++ > > target/arm/kvm.c | 7 +- > > tests/data/acpi/aarch64/virt/DSDT | Bin 5196 -> 5240 bytes > > .../data/acpi/aarch64/virt/DSDT.acpihmatvirt | Bin 5282 -> 5326 bytes > > tests/data/acpi/aarch64/virt/DSDT.memhp | Bin 6557 -> 6601 bytes > > tests/data/acpi/aarch64/virt/DSDT.pxb | Bin 7679 -> 7723 bytes > > tests/data/acpi/aarch64/virt/DSDT.topology | Bin 5398 -> 5442 bytes > > 29 files changed, 1677 insertions(+), 79 deletions(-) > > create mode 100644 hw/acpi/ghes_cper.c > > create mode 100644 hw/acpi/ghes_cper_stub.c > > create mode 100644 qapi/acpi-hest.json > > create mode 100644 scripts/arm_processor_error.py > > create mode 100755 scripts/ghes_inject.py > > create mode 100755 scripts/qmp_helper.py > > > > once you enable, ras in tests as 1st patches and fixup minor issues > please try to do patch by patch compile/bios-tables-test testing, to avoid > unnecessary respin in case at table change crept in somewhere unnoticed. Just submitted v5. I took some extra care to avoid bisect issues. Still checkpatch had some warnings, but they seemed false positives. Thanks, Mauro
Powered by blists - more mailing lists