linux-kernel - [PATCH] drm/amdgpu: Simplify maximum determination in si_calc_upll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <9574279b-6e02-467c-8e0f-28a037e061d9@web.de>
Date: Fri, 28 Feb 2025 16:45:52 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
 Alex Deucher <alexander.deucher@....com>, Boyuan Zhang
 <boyuan.zhang@....com>, Christian König
 <christian.koenig@....com>, David Airlie <airlied@...il.com>,
 Ma Jun <Jun.Ma2@....com>, Simona Vetter <simona@...ll.ch>,
 Sunil Khatri <sunil.khatri@....com>
Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org,
 Qasim Ijaz <qasdev00@...il.com>
Subject: [PATCH] drm/amdgpu: Simplify maximum determination in
 si_calc_upll_dividers()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Fri, 28 Feb 2025 16:37:00 +0100

Replace nested max() calls by single max3() call in this
function implementation.

This issue was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/gpu/drm/amd/amdgpu/si.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/si.c b/drivers/gpu/drm/amd/amdgpu/si.c
index 026e8376e2c0..2a255fb15768 100644
--- a/drivers/gpu/drm/amd/amdgpu/si.c
+++ b/drivers/gpu/drm/amd/amdgpu/si.c
@@ -1726,7 +1726,7 @@ static int si_calc_upll_dividers(struct amdgpu_device *adev,
 	unsigned optimal_score = ~0;

 	/* Loop through vco from low to high */
-	vco_min = max(max(vco_min, vclk), dclk);
+	vco_min = max3(vco_min, vclk, dclk);
 	for (vco_freq = vco_min; vco_freq <= vco_max; vco_freq += 100) {
 		uint64_t fb_div = (uint64_t)vco_freq * fb_factor;
 		unsigned vclk_div, dclk_div, score;
--
2.48.1