linux-kernel - Re: [PATCH] gpu: host1x: Remove unused host1x_debug_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8HauW1ewQoz0iLh@gallifrey>
Date: Fri, 28 Feb 2025 15:48:09 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: airlied@...il.com, simona@...ll.ch, tzimmermann@...e.de
Cc: Mikko Perttunen <cyndis@...si.fi>, thierry.reding@...il.com,
	mperttunen@...dia.com, linux-tegra@...r.kernel.org,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpu: host1x: Remove unused host1x_debug_dump_syncpts

Hi,

* Mikko Perttunen (cyndis@...si.fi) wrote:
> On 12/16/24 6:47 AM, linux@...blig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@...blig.org>
> > 
> > host1x_debug_dump_syncpts() has been unused since
> > commit f0fb260a0cdb ("gpu: host1x: Implement syncpoint wait using DMA
> > fences")
> > 
> > Remove it.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> > ---
> >   drivers/gpu/host1x/debug.c | 9 ---------
> >   drivers/gpu/host1x/debug.h | 1 -
> >   2 files changed, 10 deletions(-)
> > 
> > diff --git a/drivers/gpu/host1x/debug.c b/drivers/gpu/host1x/debug.c
> > index a18cc8d8caf5..6433c00d5d7e 100644
> > --- a/drivers/gpu/host1x/debug.c
> > +++ b/drivers/gpu/host1x/debug.c
> > @@ -216,12 +216,3 @@ void host1x_debug_dump(struct host1x *host1x)
> >   	show_all(host1x, &o, true);
> >   }
> > -
> > -void host1x_debug_dump_syncpts(struct host1x *host1x)
> > -{
> > -	struct output o = {
> > -		.fn = write_to_printk
> > -	};
> > -
> > -	show_syncpts(host1x, &o, false);
> > -}
> > diff --git a/drivers/gpu/host1x/debug.h b/drivers/gpu/host1x/debug.h
> > index 62bd8a091fa7..c43c61d876a9 100644
> > --- a/drivers/gpu/host1x/debug.h
> > +++ b/drivers/gpu/host1x/debug.h
> > @@ -41,6 +41,5 @@ extern unsigned int host1x_debug_trace_cmdbuf;
> >   void host1x_debug_init(struct host1x *host1x);
> >   void host1x_debug_deinit(struct host1x *host1x);
> >   void host1x_debug_dump(struct host1x *host1x);
> > -void host1x_debug_dump_syncpts(struct host1x *host1x);
> >   #endif
> 
> Acked-by: Mikko Perttunen <mperttunen@...dia.com>

Can this find it's way into drm please.

Thanks,

Dave

-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/