linux-kernel - Re: [PATCH] usb: replace strcpy() with strscpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025022833-unawake-barricade-7bb8@gregkh>
Date: Fri, 28 Feb 2025 09:02:10 -0800
From: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To: Aditya Garg <gargaditya08@...e.com>
Cc: "castet.matthieu@...e.fr" <castet.matthieu@...e.fr>,
	"stf_xl@...pl" <stf_xl@...pl>, "b-liu@...com" <b-liu@...com>,
	"johan@...nel.org" <johan@...nel.org>,
	"heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>,
	"valentina.manea.m@...il.com" <valentina.manea.m@...il.com>,
	"shuah@...nel.org" <shuah@...nel.org>,
	"i@...ithal.me" <i@...ithal.me>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [PATCH] usb: replace strcpy() with strscpy()

On Fri, Feb 28, 2025 at 03:07:03PM +0000, Aditya Garg wrote:
> From: Aditya Garg <gargaditya08@...e.com>
> 
> The strcpy() function has been deprecated and replaced with strscpy().
> This patch shall replace it in the whole USB tree.
> 
> Link: https://github.com/KSPP/linux/issues/88
> Signed-off-by: Aditya Garg <gargaditya08@...e.com>

As the two functions do different things, are you sure it is safe to
just do a search/replace here?  If so, you need to explain that in the
changelog why this is ok, and if not, please document that as well :)

thanks,

greg k-h