linux-kernel - Re: your mail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a05e6abc-f767-4b29-96fd-1ce055ce8a51@lucifer.local>
Date: Fri, 28 Feb 2025 17:30:09 +0000
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: Jeff Xu <jeffxu@...omium.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
        Kees Cook <keescook@...omium.org>, Jann Horn <jannh@...gle.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        "Liam R. Howlett" <Liam.Howlett@...cle.com>,
        Adhemerval Zanella Netto <adhemerval.zanella@...aro.org>,
        Oleg Nesterov <oleg@...hat.com>, Andrei Vagin <avagin@...il.com>,
        Benjamin Berg <benjamin@...solutions.net>,
        LKML <linux-kernel@...r.kernel.org>,
        "linux-hardening@...r.kernel.org" <linux-hardening@...r.kernel.org>,
        linux-mm@...ck.org, Jorge Lucangeli Obes <jorgelo@...omium.org>,
        Stephen Röttger <sroettger@...gle.com>,
        "hch@....de" <hch@....de>, "ojeda@...nel.org" <ojeda@...nel.org>,
        Thomas Weißschuh <thomas.weissschuh@...utronix.de>,
        "adobriyan@...il.com" <adobriyan@...il.com>,
        "johannes@...solutions.net" <johannes@...solutions.net>,
        Pedro Falcato <pedro.falcato@...il.com>,
        "hca@...ux.ibm.com" <hca@...ux.ibm.com>,
        Matthew Wilcox <willy@...radead.org>,
        "anna-maria@...utronix.de" <anna-maria@...utronix.de>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "Jason@...c4.com" <Jason@...c4.com>, Helge Deller <deller@....de>,
        Randy Dunlap <rdunlap@...radead.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Peter Xu <peterx@...hat.com>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "gerg@...nel.org" <gerg@...nel.org>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        Ingo Molnar <mingo@...nel.org>, "ardb@...nel.org" <ardb@...nel.org>,
        "mhocko@...e.com" <mhocko@...e.com>,
        "42.hyeyoo@...il.com" <42.hyeyoo@...il.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "ardb@...gle.com" <ardb@...gle.com>, Elliott Hughes <enh@...gle.com>,
        "rientjes@...gle.com" <rientjes@...gle.com>,
        Guenter Roeck <groeck@...omium.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Alexander Mikhalitsyn <aleksandr.mikhalitsyn@...onical.com>,
        Mike Rapoport <mike.rapoport@...il.com>
Subject: Re: your mail

On Fri, Feb 28, 2025 at 09:24:11AM -0800, Jeff Xu wrote:

[snip]

> > >
> > > When the vdso is marked with "sl", mremap() will fail, that's part of
> > > the mseal() business logic and belongs in mseal_test. The mseal_test
> > > already covers the mseal, and this series doesn't change mseal.
> > >
> > > As for the "sl", as I responded in the "refactor mseal_test" [1] , it
> > > will be part of the verifying step:
> > >
> > > [1] https://lore.kernel.org/all/CABi2SkUv_1gsuGh86AON-xRLAggCvDqJMHxT17mGy-XutSTAwg@mail.gmail.com/
> >
> > OK cool thanks. I will look at this when I can, I'm just snowed under
> > pre-LSF and have been sick so backlog, backlog as discussed off-list. But
> > it's not been forgotten (whiteboard etc. etc.)
> >
> Ya, no worry about that review, please take time to recover, I will wait.
> And appreciate your time and take priority for reviewing this series.

Thanks :)

[snip]

> > >
> > > Option two is to create a new path:
> > > tools/testing/selftests/sealsysmap. Then, add
> > > CONFIG_SEAL_SYSTEM_MAPPING=y to the config file and add a selftest to
> > > this path. This seems to be the preferred way by selftest, but we need
> > > a new dir for that.
> >
> > OK I like option 2 let's do this.
> >
> > But let's call it mseal_system_mappings (yes I"m being nitty again :) I
> > really want to try to _explicitly_ say 'mseal' because we have other forms
> > of sealing.
> >
> Sure.

Thanks!

>
> If long path names aren't a problem, I will use mseal_system_mappings,
> otherwise mseal_sysmap.

I think long form is fine.

[snip]

> > >
> > > In any case, I think the risk is low, and the code changes are quite
> > > simple, and fully tested.
> >
> > Yeah indeed, but I'd really like _something_ if possible. If option 2 is
> > relatively quick let's get that sorted out!
> >
> Great ! I will work on option 2.

Perfect cheers!

>
> Thanks
> -Jeff