linux-kernel - Re: [PATCH 01/18] rtc: max77686: drop needless struct max77686_rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24104b0c-aa80-41d7-89b0-0a253a1ccdc9@kernel.org>
Date: Fri, 28 Feb 2025 18:30:58 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: André Draszik <andre.draszik@...aro.org>,
 Chanwoo Choi <cw00.choi@...sung.com>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Joel Stanley <joel@....id.au>, Andrew Jeffery <andrew@...econstruct.com.au>,
 Hans Ulli Kroll <ulli.kroll@...glemail.com>,
 Linus Walleij <linus.walleij@...aro.org>,
 Neil Armstrong <neil.armstrong@...aro.org>,
 Kevin Hilman <khilman@...libre.com>, Jerome Brunet <jbrunet@...libre.com>,
 Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
 Tóth János <gomba007@...il.com>,
 Dianlong Li <long17.cool@....com>
Cc: linux-kernel@...r.kernel.org, linux-rtc@...r.kernel.org,
 linux-samsung-soc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-aspeed@...ts.ozlabs.org, linux-amlogic@...ts.infradead.org
Subject: Re: [PATCH 01/18] rtc: max77686: drop needless struct
 max77686_rtc_info::rtc member

On 28/02/2025 15:07, André Draszik wrote:
> When this driver was converted to using the devres managed i2c device
> in commit 59a7f24fceb3 ("rtc: max77686: convert to
> devm_i2c_new_dummy_device()"), struct max77686_rtc_info::rtc became
> essentially unused.
> 
> We can drop it from the structure and just use a local temporary
> variable, reducing runtime memory consumption by a few bytes.
> 
> Signed-off-by: André Draszik <andre.draszik@...aro.org>
> ---
>  drivers/rtc/rtc-max77686.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof