linux-kernel - [BUG objtool,x86] Missing __noreturn annotation in acpi_processor_ffh_play

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <9a09eebe-f8fa-4993-83c1-7d58abac28af@paulmck-laptop>
Date: Fri, 28 Feb 2025 11:00:07 -0800
From: "Paul E. McKenney" <paulmck@...nel.org>
To: patryk.wlazlyn@...ux.intel.com
Cc: artem.bityutskiy@...ux.intel.com, dave.hansen@...ux.intel.com,
	gautham.shenoy@....com, rafael.j.wysocki@...el.com,
	linux-kernel@...r.kernel.org, sfr@...b.auug.org.au,
	jpoimboe@...nel.org, peterz@...radead.org
Subject: [BUG objtool,x86] Missing __noreturn annotation in
 acpi_processor_ffh_play_dead()

Hello!

My recent -next testing hits this objtool complaint:

vmlinux.o: warning: objtool: acpi_idle_play_dead+0x3c: acpi_processor_ffh_play_dead() is missing a __noreturn annotation

My attempts to silence this by adding the suggested __noreturn annotations
didn't help, and often got me compiler warnings about __noreturn functions
actually returning.  So I bisected, which converges on this innocent-looking
commit:

a7dd183f0b38 ("x86/smp: Allow calling mwait_play_dead with an arbitrary hint")

Several runs verified that this really is the commit that objtool is
complaining about.  Unfortunately, this commit does not revert cleanly.

This is from builds using clang version 19.1.5 (CentOS 19.1.5-2.el9).

Help?

							Thanx, Paul