linux-kernel - Re: [PATCH net-next 3/6] net/mlx5e: Enable lanes configuration when auto-negotiation is off

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250228145135.57cf1a73@kernel.org>
Date: Fri, 28 Feb 2025 14:51:35 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Tariq Toukan <tariqt@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>, Paolo Abeni
 <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>, "Andrew Lunn"
 <andrew+netdev@...n.ch>, Saeed Mahameed <saeedm@...dia.com>, Gal Pressman
 <gal@...dia.com>, "Leon Romanovsky" <leonro@...dia.com>, Leon Romanovsky
 <leon@...nel.org>, <netdev@...r.kernel.org>, <linux-rdma@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, Shahar Shitrit <shshitrit@...dia.com>,
 Carolina Jubran <cjubran@...dia.com>
Subject: Re: [PATCH net-next 3/6] net/mlx5e: Enable lanes configuration when
 auto-negotiation is off

On Wed, 26 Feb 2025 13:47:49 +0200 Tariq Toukan wrote:
> +		if (table[i].speed == info->speed) {
> +			if (!info->lanes || table[i].lanes == info->lanes)

Hm, on a quick look it seems like lane count was added in all tables,
so not sure why the !info->lanes

> +				link_modes |= MLX5E_PROT_MASK(i);