linux-kernel - Re: [PATCH net-next 3/6] net/mlx5e: Enable lanes configuration when auto-negotiation is off

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250228155437.0a6ec42a@kernel.org>
Date: Fri, 28 Feb 2025 15:54:37 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Tariq Toukan <tariqt@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>, Paolo Abeni
 <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>, "Andrew Lunn"
 <andrew+netdev@...n.ch>, Saeed Mahameed <saeedm@...dia.com>, Gal Pressman
 <gal@...dia.com>, "Leon Romanovsky" <leonro@...dia.com>, Leon Romanovsky
 <leon@...nel.org>, <netdev@...r.kernel.org>, <linux-rdma@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, Shahar Shitrit <shshitrit@...dia.com>,
 Carolina Jubran <cjubran@...dia.com>
Subject: Re: [PATCH net-next 3/6] net/mlx5e: Enable lanes configuration when
 auto-negotiation is off

On Wed, 26 Feb 2025 13:47:49 +0200 Tariq Toukan wrote:
> diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
> index 84833cca29fe..49d50afb102c 100644
> --- a/include/uapi/linux/ethtool.h
> +++ b/include/uapi/linux/ethtool.h
> @@ -2192,6 +2192,8 @@ enum ethtool_link_mode_bit_indices {
>  #define SPEED_800000		800000
>  
>  #define SPEED_UNKNOWN		-1
> +#define LANES_UNKNOWN		 0
> +#define MAX_LANES		 8

Almost missed this.

Any reason you're adding to the uAPI header?
Just because that's where SPEED_UNKNOWN is defined?
IIRC lanes are only reported via netlink, so we don't need 
to worry about sharing unspecified values with user space.
Stuff added to the uAPI header is harder to clean up,
if you don't have a strong reason I think we should move 
these defines to the kernel header.
-- 
pw-bot: cr