linux-kernel - Re: [PATCH v3 net-next 2/6] net: hibmcge: Add support for rx checksum offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <69aae0dd-78f4-47e0-bb86-1d314588e7ad@huawei.com>
Date: Fri, 28 Feb 2025 09:04:49 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <shaojijie@...wei.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<pabeni@...hat.com>, <andrew+netdev@...n.ch>, <horms@...nel.org>,
	<shenjian15@...wei.com>, <wangpeiyang1@...wei.com>, <liuyonglong@...wei.com>,
	<chenhao418@...wei.com>, <sudongming1@...wei.com>, <xujunsheng@...wei.com>,
	<shiyongbang@...wei.com>, <libaihan@...wei.com>,
	<jonathan.cameron@...wei.com>, <shameerali.kolothum.thodi@...wei.com>,
	<salil.mehta@...wei.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <kalesh-anakkur.purayil@...adcom.com>
Subject: Re: [PATCH v3 net-next 2/6] net: hibmcge: Add support for rx checksum
 offload


on 2025/2/27 22:47, Jakub Kicinski wrote:
> On Thu, 27 Feb 2025 19:28:25 +0800 Jijie Shao wrote:
>> rx checksum offload enable:
>> 	device check ok ->  CHECKSUM_UNNECESSARY -> stack
>> 	device check fail ->  drop
> Don't drop packets on csum validation failure.
> The stack can easily handle packets with bad csum.
> And users will monitor stack metrics for csum errors.
> Plus devices are wrong more often than the stack.

OK, I'll modify this in the v4 and modify the statistics as well.

Thanks,
Jijie Shao