linux-kernel - Re: [PATCH v1] rtla: Save trace when option `--trace` is specified

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250227200623.60f20571@gandalf.local.home>
Date: Thu, 27 Feb 2025 20:06:31 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Costa Shulyupin <costa.shul@...hat.com>
Cc: John Kacur <jkacur@...hat.com>, Tomas Glozar <tglozar@...hat.com>, "Luis
 Claudio R. Goncalves" <lgoncalv@...hat.com>, Eder Zulian
 <ezulian@...hat.com>, Dan Carpenter <dan.carpenter@...aro.org>,
 linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] rtla: Save trace when option `--trace` is specified

On Mon, 27 Jan 2025 19:02:40 +0200
Costa Shulyupin <costa.shul@...hat.com> wrote:

> +++ b/tools/tracing/rtla/src/osnoise_hist.c
> @@ -981,12 +981,11 @@ int osnoise_hist_main(int argc, char *argv[])
>  
>  	return_value = 0;
>  
> -	if (osnoise_trace_is_off(tool, record)) {
> +	if (osnoise_trace_is_off(tool, record))
>  		printf("rtla osnoise hit stop tracing\n");
> -		if (params->trace_output) {
> -			printf("  Saving trace to %s\n", params->trace_output);
> -			save_trace_to_file(record->trace.inst, params->trace_output);
> -		}
> +	if (params->trace_output) {
> +		printf("  Saving trace to %s\n", params->trace_output);
> +		save_trace_to_file(record->trace.inst, params->trace_output);
>  	}

Without tracing being off, this can run forever if the events come in
faster than it can be recorded. And save trace uses the "trace" file, which
is slow to read.

Are you sure you want that?

-- Steve