linux-kernel - Re: [PATCH RESEND v3] drm/xe: xe_gen_wa_oob: replace program_invocation_short

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4ghuhfcasawko7ultvuou3dhfzvb4fm4kazdd6ld5aquwvpzyh@xg2tdw5zi37j>
Date: Fri, 28 Feb 2025 09:55:57 +0100
From: Daniel Gomez <da.gomez@...nel.org>
To: Lucas De Marchi <lucas.demarchi@...el.com>
Cc: Tamir Duberstein <tamird@...il.com>, 
	Thomas Hellström <thomas.hellstrom@...ux.intel.com>, Rodrigo Vivi <rodrigo.vivi@...el.com>, 
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers <nick.desaulniers+lkml@...il.com>, 
	Bill Wendling <morbo@...gle.com>, Masahiro Yamada <masahiroy@...nel.org>, 
	Justin Stitt <justinstitt@...gle.com>, intel-xe@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org, llvm@...ts.linux.dev, Klaus Jensen <k.jensen@...sung.com>, 
	Theodore Ts'o <tytso@....edu>, gost.dev@...sung.com, Barry Song <baohua@...nel.org>, 
	Daniel Gomez <da.gomez@...sung.com>
Subject: Re: [PATCH RESEND v3] drm/xe: xe_gen_wa_oob: replace
 program_invocation_short_name

On Thu, Feb 27, 2025 at 01:09:55PM +0100, Lucas De Marchi wrote:
> On Thu, Feb 27, 2025 at 08:39:21AM -0500, Tamir Duberstein wrote:
> > Hi Lucas, chiming in here since I also care about building on macOS.
> > 
> > On Mon, Feb 24, 2025 at 10:05 AM Lucas De Marchi
> > <lucas.demarchi@...el.com> wrote:
> > > 
> > > Is this the approach taken for other similar issues you had? Note that
> > > argv[0] and program_invocation_short_name are not the same thing. For
> > > this particular binary I don't really care and if it's the approach
> > > taken in other places, I'm ok using it.
> > 
> > Believe it or not, this is the only place that
> > program_invocation_short_name has ever been used in the kernel. There
> > have been numerous instances of:
> > 
> > #define _GNU_SOURCE /* for program_invocation_short_name */
> > 
> > but never any actual callers (that I could find in the git history)
> > other than this one.
> > 
> > > I was expecting you'd take the acks and merge it all through a single
> > > tree since you received push back on the need to build the kernel in
> > > macOS.  Is this the only thing missing and you'd want it to go through
> > > drm?

Yes, this is the only one missing.

> > 
> > I believe the other patches have been applied or dropped. When I last
> > tested building allmodconfig this was the only issue I ran into (macOS
> > arm64), so I asked Daniel for this resend.

That is correct.

In my opinion, the support for building the Linux kernel on macOS is primarily
supported by LLVM/Clang and the Linux kernel build system. The merged patches
were merely minor tweaks such this one (and refactors from Masahiro), intended
to enable users to configure the build system on these platforms. Patches
dropped led to the creation of the bee-headers project, which allows users
customize their build setup, which seems to be a common practice when people
requires to tweak the build environment.

> 
> fair enough.  Pushed to drm-xe-next since nobody ever reads the
> usage for this helper tool and it doesn't really matter if now it's ugly.

Thanks!

With this, we can now build arm64 in macOS defconfig, allyesconfig and
allmodconfig targets even with Rust support!

Daniel

> 
> Lucas De Marchi
> 
> > 
> > Cheers.
> > Tamir