linux-kernel - Re: [PATCH v2 8/8] drm/msm/dpu: drop now-unused condition for has_legacy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA752964-870A-4DB9-A6F7-0E701EA24AB2@somainline.org>
Date: Fri, 28 Feb 2025 10:08:47 +0100
From: Marijn Suijten <marijn.suijten@...ainline.org>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Rob Clark <robdclark@...il.com>, Abhinav Kumar <quic_abhinavk@...cinc.com>,
 Sean Paul <sean@...rly.run>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>
CC: linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 freedreno@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 8/8] drm/msm/dpu: drop now-unused condition for has_legacy_ctls

On 28 February 2025 05:14:12 CET, Dmitry Baryshkov <dmitry.baryshkov@...aro.org> wrote:
>Now as we have dropped the DPU_CTL_SPLIT_DISPLAY from DPU >= 5.0
>configuration, drop the rm->has_legacy_ctl condition which short-cutted
>the check for those platforms.
>
>Suggested-by: Marijn Suijten <marijn.suijten@...ainline.org>
>Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>
>---
>
>Note, it is imposible to reoder commits in any other sensible way. The

Reorder :)

>DPU_CTL_SPLIT_DISPLAY can not be dropped before the patch that enables
>single-CTL support.

Maybe I expected this note on patch 4/6 introducing it, but it disappears after merging anyway so that's a mega-nit. Thanks for sending this!

Reviewed-by: Marijn Suijten <marijn.suijten@...ainline.org>

>---
> drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
>index 4dbc9bc7eb4f151f83055220665ee5fd238ae7ba..2557effe639b5360bc948a49b0cccdb59ee35dab 100644
>--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
>+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
>@@ -410,8 +410,7 @@ static int _dpu_rm_reserve_ctls(
> 
> 		DPU_DEBUG("ctl %d caps 0x%lX\n", j + CTL_0, features);
> 
>-		if (rm->has_legacy_ctls &&
>-		    needs_split_display != has_split_display)
>+		if (needs_split_display != has_split_display)
> 			continue;
> 
> 		ctl_idx[i] = j;
>