linux-kernel - Re: [PATCH v3 3/3] dt-bindings: net: phy: add BCM63268 GPHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <174070594941.726878.5388041268672454945.robh@kernel.org>
Date: Thu, 27 Feb 2025 19:25:49 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Kyle Hendry <kylehendrydev@...il.com>
Cc: Jakub Kicinski <kuba@...nel.org>, 
 Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, 
 jonas.gorski@...il.com, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 netdev@...r.kernel.org, Philipp Zabel <p.zabel@...gutronix.de>, 
 Conor Dooley <conor+dt@...nel.org>, Heiner Kallweit <hkallweit1@...il.com>, 
 linux-kernel@...r.kernel.org, noltari@...il.com, 
 "David S. Miller" <davem@...emloft.net>, 
 Russell King <linux@...linux.org.uk>, 
 Florian Fainelli <florian.fainelli@...adcom.com>, 
 devicetree@...r.kernel.org, Paolo Abeni <pabeni@...hat.com>, 
 Eric Dumazet <edumazet@...gle.com>, Andrew Lunn <andrew+netdev@...n.ch>
Subject: Re: [PATCH v3 3/3] dt-bindings: net: phy: add BCM63268 GPHY

On Thu, 27 Feb 2025 16:27:17 -0800, Kyle Hendry wrote:
> Add YAML bindings for BCM63268 internal GPHY
> 
> Signed-off-by: Kyle Hendry <kylehendrydev@...il.com>
> ---
>  .../bindings/net/brcm,bcm63268-gphy.yaml      | 51 +++++++++++++++++++
>  1 file changed, 51 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/brcm,bcm63268-gphy.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/brcm,bcm63268-gphy.yaml: maintainers:0: 'TBD' does not match '@'
	from schema $id: http://devicetree.org/meta-schemas/base.yaml#
Error: Documentation/devicetree/bindings/net/brcm,bcm63268-gphy.example.dts:26.39-40 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/net/brcm,bcm63268-gphy.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1511: dt_binding_check] Error 2
make: *** [Makefile:251: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250228002722.5619-4-kylehendrydev@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.