linux-kernel - Re: [PATCH v2 10/16] selftests: vDSO: vdso_standalone_test_x86: Use vdso_init_form_sysinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe56c774-dcd8-475f-8008-e5baa87908ef@arm.com>
Date: Fri, 28 Feb 2025 12:28:06 +0000
From: Vincenzo Frascino <vincenzo.frascino@....com>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>,
 Kees Cook <kees@...nel.org>, Eric Biederman <ebiederm@...ssion.com>,
 Shuah Khan <shuah@...nel.org>, Nathan Chancellor <nathan@...nel.org>,
 Nick Desaulniers <ndesaulniers@...gle.com>, Bill Wendling
 <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>,
 Andy Lutomirski <luto@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
 Willy Tarreau <w@....eu>, Thomas Weißschuh
 <linux@...ssschuh.net>
Cc: "Jason A. Donenfeld" <Jason@...c4.com>,
 Christophe Leroy <christophe.leroy@...roup.eu>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
 llvm@...ts.linux.dev
Subject: Re: [PATCH v2 10/16] selftests: vDSO: vdso_standalone_test_x86: Use
 vdso_init_form_sysinfo_ehdr

On 26/02/2025 11:44, Thomas Weißschuh wrote:
> vdso_standalone_test_x86 is the only user of vdso_init_from_auxv().
> Instead of combining the parsing the aux vector with the parsing of the
> vDSO, split them apart into getauxval() and the regular
> vdso_init_from_sysinfo_ehdr().
> 
> The implementation of getauxval() is taken from
> tools/include/nolibc/stdlib.h.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
> 

Reviewed-by: Vincenzo Frascino <vincenzo.frascino@....com>

> ---
> All of this code will be deleted later again.
> ---
>  .../selftests/vDSO/vdso_standalone_test_x86.c      | 27 +++++++++++++++++++++-
>  1 file changed, 26 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/vDSO/vdso_standalone_test_x86.c b/tools/testing/selftests/vDSO/vdso_standalone_test_x86.c
> index 644915862af8883131e5defd336f1bd80736fc0f..500608f89c66b5747e3d845ebc54e4c3a35b6ccd 100644
> --- a/tools/testing/selftests/vDSO/vdso_standalone_test_x86.c
> +++ b/tools/testing/selftests/vDSO/vdso_standalone_test_x86.c
> @@ -15,6 +15,7 @@
>  #include <sys/time.h>
>  #include <unistd.h>
>  #include <stdint.h>
> +#include <linux/auxvec.h>
>  
>  #include "parse_vdso.h"
>  
> @@ -84,6 +85,30 @@ void to_base10(char *lastdig, time_t n)
>  	}
>  }
>  
> +unsigned long getauxval(const unsigned long *auxv, unsigned long type)
> +{
> +	unsigned long ret;
> +
> +	if (!auxv)
> +		return 0;
> +
> +	while (1) {
> +		if (!auxv[0] && !auxv[1]) {
> +			ret = 0;
> +			break;
> +		}
> +
> +		if (auxv[0] == type) {
> +			ret = auxv[1];
> +			break;
> +		}
> +
> +		auxv += 2;
> +	}
> +
> +	return ret;
> +}
> +
>  void c_main(void **stack)
>  {
>  	/* Parse the stack */
> @@ -96,7 +121,7 @@ void c_main(void **stack)
>  	stack++;
>  
>  	/* Now we're pointing at auxv.  Initialize the vDSO parser. */
> -	vdso_init_from_auxv((void *)stack);
> +	vdso_init_from_sysinfo_ehdr(getauxval((unsigned long *)stack, AT_SYSINFO_EHDR));
>  
>  	/* Find gettimeofday. */
>  	typedef long (*gtod_t)(struct timeval *tv, struct timezone *tz);
> 

-- 
Regards,
Vincenzo