linux-kernel - Re: [PATCH v2 11/16] selftests: vDSO: parse_vdso: Drop vdso_init_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63018d3b-9c80-465f-be5c-34eb8255109c@arm.com>
Date: Fri, 28 Feb 2025 12:28:34 +0000
From: Vincenzo Frascino <vincenzo.frascino@....com>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>,
 Kees Cook <kees@...nel.org>, Eric Biederman <ebiederm@...ssion.com>,
 Shuah Khan <shuah@...nel.org>, Nathan Chancellor <nathan@...nel.org>,
 Nick Desaulniers <ndesaulniers@...gle.com>, Bill Wendling
 <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>,
 Andy Lutomirski <luto@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
 Willy Tarreau <w@....eu>, Thomas Weißschuh
 <linux@...ssschuh.net>
Cc: "Jason A. Donenfeld" <Jason@...c4.com>,
 Christophe Leroy <christophe.leroy@...roup.eu>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
 llvm@...ts.linux.dev
Subject: Re: [PATCH v2 11/16] selftests: vDSO: parse_vdso: Drop
 vdso_init_from_auxv()

On 26/02/2025 11:44, Thomas Weißschuh wrote:
> There are no users left.
> 
> This also removes the usage of ElfXX_auxv_t,
> which is not formally standardized.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>

Reviewed-by: Vincenzo Frascino <vincenzo.frascino@....com>

> ---
>  tools/testing/selftests/vDSO/parse_vdso.c | 14 --------------
>  tools/testing/selftests/vDSO/parse_vdso.h |  1 -
>  2 files changed, 15 deletions(-)
> 
> diff --git a/tools/testing/selftests/vDSO/parse_vdso.c b/tools/testing/selftests/vDSO/parse_vdso.c
> index 2fe5e983cb22f1ed066d0310a54f6aef2ed77ed8..3638fe605e80ca41b29d43c6ac452964eef35d56 100644
> --- a/tools/testing/selftests/vDSO/parse_vdso.c
> +++ b/tools/testing/selftests/vDSO/parse_vdso.c
> @@ -297,17 +297,3 @@ void *vdso_sym(const char *version, const char *name)
>  
>  	return 0;
>  }
> -
> -void vdso_init_from_auxv(void *auxv)
> -{
> -	ELF(auxv_t) *elf_auxv = auxv;
> -	for (int i = 0; elf_auxv[i].a_type != AT_NULL; i++)
> -	{
> -		if (elf_auxv[i].a_type == AT_SYSINFO_EHDR) {
> -			vdso_init_from_sysinfo_ehdr(elf_auxv[i].a_un.a_val);
> -			return;
> -		}
> -	}
> -
> -	vdso_info.valid = false;
> -}
> diff --git a/tools/testing/selftests/vDSO/parse_vdso.h b/tools/testing/selftests/vDSO/parse_vdso.h
> index de0453067d7cd0d8b63f7d3738842f60370db813..09d068ed11f97f0c5c8f4e7b341f08fa261c9735 100644
> --- a/tools/testing/selftests/vDSO/parse_vdso.h
> +++ b/tools/testing/selftests/vDSO/parse_vdso.h
> @@ -26,6 +26,5 @@
>   */
>  void *vdso_sym(const char *version, const char *name);
>  void vdso_init_from_sysinfo_ehdr(uintptr_t base);
> -void vdso_init_from_auxv(void *auxv);
>  
>  #endif
> 

-- 
Regards,
Vincenzo