linux-kernel - Re: [PATCH v2 12/16] selftests: vDSO: parse_vdso: Use UAPI headers instead of libc headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3440d93a-86e2-4dd3-80f8-dc7daa0aff41@arm.com>
Date: Fri, 28 Feb 2025 12:29:00 +0000
From: Vincenzo Frascino <vincenzo.frascino@....com>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>,
 Kees Cook <kees@...nel.org>, Eric Biederman <ebiederm@...ssion.com>,
 Shuah Khan <shuah@...nel.org>, Nathan Chancellor <nathan@...nel.org>,
 Nick Desaulniers <ndesaulniers@...gle.com>, Bill Wendling
 <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>,
 Andy Lutomirski <luto@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
 Willy Tarreau <w@....eu>, Thomas Weißschuh
 <linux@...ssschuh.net>
Cc: "Jason A. Donenfeld" <Jason@...c4.com>,
 Christophe Leroy <christophe.leroy@...roup.eu>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
 llvm@...ts.linux.dev
Subject: Re: [PATCH v2 12/16] selftests: vDSO: parse_vdso: Use UAPI headers
 instead of libc headers

On 26/02/2025 11:44, Thomas Weißschuh wrote:
> To allow the usage of parse_vdso.c together with a limited libc like
> nolibc, use the kernels own elf.h and auxvec.h headers.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>

Reviewed-by: Vincenzo Frascino <vincenzo.frascino@....com>

> ---
>  tools/testing/selftests/vDSO/Makefile     | 3 +++
>  tools/testing/selftests/vDSO/parse_vdso.c | 3 ++-
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/vDSO/Makefile b/tools/testing/selftests/vDSO/Makefile
> index 1cf14a8da43803249f72fe1b09689c8834806986..bc8ca186fb877dc11740c37f1e07e45e84c2ae92 100644
> --- a/tools/testing/selftests/vDSO/Makefile
> +++ b/tools/testing/selftests/vDSO/Makefile
> @@ -19,6 +19,9 @@ LDLIBS += -lgcc_s
>  endif
>  
>  include ../lib.mk
> +
> +CFLAGS += $(TOOLS_INCLUDES)
> +
>  $(OUTPUT)/vdso_test_gettimeofday: parse_vdso.c vdso_test_gettimeofday.c
>  $(OUTPUT)/vdso_test_getcpu: parse_vdso.c vdso_test_getcpu.c
>  $(OUTPUT)/vdso_test_abi: parse_vdso.c vdso_test_abi.c
> diff --git a/tools/testing/selftests/vDSO/parse_vdso.c b/tools/testing/selftests/vDSO/parse_vdso.c
> index 3638fe605e80ca41b29d43c6ac452964eef35d56..200c534cc70e2c2381fce3be5c0ebe4cb5675e84 100644
> --- a/tools/testing/selftests/vDSO/parse_vdso.c
> +++ b/tools/testing/selftests/vDSO/parse_vdso.c
> @@ -19,7 +19,8 @@
>  #include <stdint.h>
>  #include <string.h>
>  #include <limits.h>
> -#include <elf.h>
> +#include <linux/auxvec.h>
> +#include <linux/elf.h>
>  
>  #include "parse_vdso.h"
>  
> 

-- 
Regards,
Vincenzo