linux-kernel - Re: [PATCH v2 15/16] selftests: vDSO: vdso_test_gettimeofday: Make compatible with nolibc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02b4e5ba-b740-4da4-8a6b-9a5e325b3e8f@arm.com>
Date: Fri, 28 Feb 2025 12:30:22 +0000
From: Vincenzo Frascino <vincenzo.frascino@....com>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>,
 Kees Cook <kees@...nel.org>, Eric Biederman <ebiederm@...ssion.com>,
 Shuah Khan <shuah@...nel.org>, Nathan Chancellor <nathan@...nel.org>,
 Nick Desaulniers <ndesaulniers@...gle.com>, Bill Wendling
 <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>,
 Andy Lutomirski <luto@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
 Willy Tarreau <w@....eu>, Thomas Weißschuh
 <linux@...ssschuh.net>
Cc: "Jason A. Donenfeld" <Jason@...c4.com>,
 Christophe Leroy <christophe.leroy@...roup.eu>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
 llvm@...ts.linux.dev
Subject: Re: [PATCH v2 15/16] selftests: vDSO: vdso_test_gettimeofday: Make
 compatible with nolibc

On 26/02/2025 11:44, Thomas Weißschuh wrote:
> nolibc does not provide sys/time.h and sys/auxv.h,
> instead their definitions are available unconditionally.
> 
> Guard the includes so they are not attempted on nolibc.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>

Reviewed-by: Vincenzo Frascino <vincenzo.frascino@....com>

> ---
>  tools/testing/selftests/vDSO/vdso_test_gettimeofday.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/vDSO/vdso_test_gettimeofday.c b/tools/testing/selftests/vDSO/vdso_test_gettimeofday.c
> index 636a56ccf8e4e7943ca446fe3fad6897598ca77f..9ce795b806f0992b83cef78c7e16fac0e54750da 100644
> --- a/tools/testing/selftests/vDSO/vdso_test_gettimeofday.c
> +++ b/tools/testing/selftests/vDSO/vdso_test_gettimeofday.c
> @@ -11,8 +11,10 @@
>   */
>  
>  #include <stdio.h>
> +#ifndef NOLIBC
>  #include <sys/auxv.h>
>  #include <sys/time.h>
> +#endif
>  
>  #include "../kselftest.h"
>  #include "parse_vdso.h"
> 

-- 
Regards,
Vincenzo