| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202503021157.kNEEt0fK-lkp@intel.com>
Date: Sun, 2 Mar 2025 12:04:22 +0800
From: kernel test robot <lkp@...el.com>
To: Dave Penkler <dpenkler@...il.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: drivers/staging/gpib/eastwood/fluke_gpib.c:1013:28: error: implicit
declaration of function 'ioremap'; did you mean 'iounmap'?
Hi Dave,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: ece144f151ac7bf8bb5b98f7d4aeeda7a2eed02a
commit: 165e8cc3cfec9ef51f3376b0d49b115294f34f3b staging: gpib: Add KBUILD files for GPIB drivers
date: 5 months ago
config: s390-randconfig-r064-20250302 (https://download.01.org/0day-ci/archive/20250302/202503021157.kNEEt0fK-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250302/202503021157.kNEEt0fK-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503021157.kNEEt0fK-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/staging/gpib/eastwood/fluke_gpib.c: In function 'fluke_line_status':
drivers/staging/gpib/eastwood/fluke_gpib.c:196:30: warning: variable 'nec_priv' set but not used [-Wunused-but-set-variable]
196 | struct nec7210_priv *nec_priv;
| ^~~~~~~~
drivers/staging/gpib/eastwood/fluke_gpib.c: In function 'fluke_attach_impl':
>> drivers/staging/gpib/eastwood/fluke_gpib.c:1013:28: error: implicit declaration of function 'ioremap'; did you mean 'iounmap'? [-Wimplicit-function-declaration]
1013 | nec_priv->iobase = ioremap(e_priv->gpib_iomem_res->start,
| ^~~~~~~
| iounmap
>> drivers/staging/gpib/eastwood/fluke_gpib.c:1013:26: error: assignment to 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
1013 | nec_priv->iobase = ioremap(e_priv->gpib_iomem_res->start,
| ^
drivers/staging/gpib/eastwood/fluke_gpib.c:1050:40: error: assignment to 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
1050 | e_priv->write_transfer_counter = ioremap(e_priv->write_transfer_counter_res->start,
| ^
In file included from drivers/staging/gpib/eastwood/fluke_gpib.c:10:
drivers/staging/gpib/eastwood/fluke_gpib.h: At top level:
drivers/staging/gpib/eastwood/fluke_gpib.h:140:18: warning: 'fluke_num_regs' defined but not used [-Wunused-const-variable=]
140 | static const int fluke_num_regs = 8;
| ^~~~~~~~~~~~~~
In file included from drivers/staging/gpib/include/nec7210.h:17,
from drivers/staging/gpib/eastwood/fluke_gpib.h:13:
drivers/staging/gpib/include/nec7210_registers.h:21:18: warning: 'nec7210_num_registers' defined but not used [-Wunused-const-variable=]
21 | static const int nec7210_num_registers = 8;
| ^~~~~~~~~~~~~~~~~~~~~
In file included from drivers/staging/gpib/include/gpib_types.h:16,
from drivers/staging/gpib/include/nec7210.h:16:
drivers/staging/gpib/uapi/gpib_user.h:344:18: warning: 'request_service_bit' defined but not used [-Wunused-const-variable=]
344 | static const int request_service_bit = 0x40;
| ^~~~~~~~~~~~~~~~~~~
drivers/staging/gpib/uapi/gpib_user.h:264:18: warning: 'gpib_addr_max' defined but not used [-Wunused-const-variable=]
264 | static const int gpib_addr_max = 30; /* max address for primary/secondary gpib addresses */
| ^~~~~~~~~~~~~
drivers/staging/gpib/uapi/gpib_user.h:212:22: warning: 'gpib_command_mask' defined but not used [-Wunused-const-variable=]
212 | static const uint8_t gpib_command_mask = 0x7f;
| ^~~~~~~~~~~~~~~~~
drivers/staging/gpib/uapi/gpib_user.h:53:18: warning: 'board_status_mask' defined but not used [-Wunused-const-variable=]
53 | static const int board_status_mask = ERR | TIMO | END | CMPL | SPOLL |
| ^~~~~~~~~~~~~~~~~
drivers/staging/gpib/uapi/gpib_user.h:52:18: warning: 'device_status_mask' defined but not used [-Wunused-const-variable=]
52 | static const int device_status_mask = ERR | TIMO | END | CMPL | RQS;
| ^~~~~~~~~~~~~~~~~~
vim +1013 drivers/staging/gpib/eastwood/fluke_gpib.c
55936779f49612 Dave Penkler 2024-09-18 973
55936779f49612 Dave Penkler 2024-09-18 974 static int fluke_attach_impl(gpib_board_t *board, const gpib_board_config_t *config,
55936779f49612 Dave Penkler 2024-09-18 975 unsigned int handshake_mode)
55936779f49612 Dave Penkler 2024-09-18 976 {
55936779f49612 Dave Penkler 2024-09-18 977 struct fluke_priv *e_priv;
55936779f49612 Dave Penkler 2024-09-18 978 struct nec7210_priv *nec_priv;
55936779f49612 Dave Penkler 2024-09-18 979 int isr_flags = 0;
55936779f49612 Dave Penkler 2024-09-18 980 int retval;
55936779f49612 Dave Penkler 2024-09-18 981 int irq;
55936779f49612 Dave Penkler 2024-09-18 982 struct resource *res;
55936779f49612 Dave Penkler 2024-09-18 983 dma_cap_mask_t dma_cap;
55936779f49612 Dave Penkler 2024-09-18 984
55936779f49612 Dave Penkler 2024-09-18 985 if (!fluke_gpib_pdev) {
55936779f49612 Dave Penkler 2024-09-18 986 pr_err("No gpib platform device was found, attach failed.\n");
55936779f49612 Dave Penkler 2024-09-18 987 return -ENODEV;
55936779f49612 Dave Penkler 2024-09-18 988 }
55936779f49612 Dave Penkler 2024-09-18 989
55936779f49612 Dave Penkler 2024-09-18 990 retval = fluke_generic_attach(board);
55936779f49612 Dave Penkler 2024-09-18 991 if (retval)
55936779f49612 Dave Penkler 2024-09-18 992 return retval;
55936779f49612 Dave Penkler 2024-09-18 993
55936779f49612 Dave Penkler 2024-09-18 994 e_priv = board->private_data;
55936779f49612 Dave Penkler 2024-09-18 995 nec_priv = &e_priv->nec7210_priv;
55936779f49612 Dave Penkler 2024-09-18 996 nec_priv->offset = fluke_reg_offset;
55936779f49612 Dave Penkler 2024-09-18 997 board->dev = &fluke_gpib_pdev->dev;
55936779f49612 Dave Penkler 2024-09-18 998
55936779f49612 Dave Penkler 2024-09-18 999 res = platform_get_resource(fluke_gpib_pdev, IORESOURCE_MEM, 0);
55936779f49612 Dave Penkler 2024-09-18 1000 if (!res) {
55936779f49612 Dave Penkler 2024-09-18 1001 dev_err(&fluke_gpib_pdev->dev, "Unable to locate mmio resource for cb7210 gpib\n");
55936779f49612 Dave Penkler 2024-09-18 1002 return -ENODEV;
55936779f49612 Dave Penkler 2024-09-18 1003 }
55936779f49612 Dave Penkler 2024-09-18 1004
55936779f49612 Dave Penkler 2024-09-18 1005 if (request_mem_region(res->start,
55936779f49612 Dave Penkler 2024-09-18 1006 resource_size(res),
55936779f49612 Dave Penkler 2024-09-18 1007 fluke_gpib_pdev->name) == NULL) {
55936779f49612 Dave Penkler 2024-09-18 1008 dev_err(&fluke_gpib_pdev->dev, "cannot claim registers\n");
55936779f49612 Dave Penkler 2024-09-18 1009 return -ENXIO;
55936779f49612 Dave Penkler 2024-09-18 1010 }
55936779f49612 Dave Penkler 2024-09-18 1011 e_priv->gpib_iomem_res = res;
55936779f49612 Dave Penkler 2024-09-18 1012
55936779f49612 Dave Penkler 2024-09-18 @1013 nec_priv->iobase = ioremap(e_priv->gpib_iomem_res->start,
55936779f49612 Dave Penkler 2024-09-18 1014 resource_size(e_priv->gpib_iomem_res));
55936779f49612 Dave Penkler 2024-09-18 1015 pr_info("gpib: iobase %lx remapped to %p, length=%d\n",
55936779f49612 Dave Penkler 2024-09-18 1016 (unsigned long)e_priv->gpib_iomem_res->start,
55936779f49612 Dave Penkler 2024-09-18 1017 nec_priv->iobase, (int)resource_size(e_priv->gpib_iomem_res));
55936779f49612 Dave Penkler 2024-09-18 1018 if (!nec_priv->iobase) {
55936779f49612 Dave Penkler 2024-09-18 1019 dev_err(&fluke_gpib_pdev->dev, "Could not map I/O memory\n");
55936779f49612 Dave Penkler 2024-09-18 1020 return -ENOMEM;
55936779f49612 Dave Penkler 2024-09-18 1021 }
55936779f49612 Dave Penkler 2024-09-18 1022
55936779f49612 Dave Penkler 2024-09-18 1023 res = platform_get_resource(fluke_gpib_pdev, IORESOURCE_MEM, 1);
55936779f49612 Dave Penkler 2024-09-18 1024 if (!res) {
55936779f49612 Dave Penkler 2024-09-18 1025 dev_err(&fluke_gpib_pdev->dev, "Unable to locate mmio resource for gpib dma port\n");
55936779f49612 Dave Penkler 2024-09-18 1026 return -ENODEV;
55936779f49612 Dave Penkler 2024-09-18 1027 }
55936779f49612 Dave Penkler 2024-09-18 1028 if (request_mem_region(res->start,
55936779f49612 Dave Penkler 2024-09-18 1029 resource_size(res),
55936779f49612 Dave Penkler 2024-09-18 1030 fluke_gpib_pdev->name) == NULL) {
55936779f49612 Dave Penkler 2024-09-18 1031 dev_err(&fluke_gpib_pdev->dev, "cannot claim registers\n");
55936779f49612 Dave Penkler 2024-09-18 1032 return -ENXIO;
55936779f49612 Dave Penkler 2024-09-18 1033 }
55936779f49612 Dave Penkler 2024-09-18 1034 e_priv->dma_port_res = res;
55936779f49612 Dave Penkler 2024-09-18 1035
55936779f49612 Dave Penkler 2024-09-18 1036 res = platform_get_resource(fluke_gpib_pdev, IORESOURCE_MEM, 2);
55936779f49612 Dave Penkler 2024-09-18 1037 if (!res) {
55936779f49612 Dave Penkler 2024-09-18 1038 dev_err(&fluke_gpib_pdev->dev, "Unable to locate mmio resource for write transfer counter\n");
55936779f49612 Dave Penkler 2024-09-18 1039 return -ENODEV;
55936779f49612 Dave Penkler 2024-09-18 1040 }
55936779f49612 Dave Penkler 2024-09-18 1041
55936779f49612 Dave Penkler 2024-09-18 1042 if (request_mem_region(res->start,
55936779f49612 Dave Penkler 2024-09-18 1043 resource_size(res),
55936779f49612 Dave Penkler 2024-09-18 1044 fluke_gpib_pdev->name) == NULL) {
55936779f49612 Dave Penkler 2024-09-18 1045 dev_err(&fluke_gpib_pdev->dev, "cannot claim registers\n");
55936779f49612 Dave Penkler 2024-09-18 1046 return -ENXIO;
55936779f49612 Dave Penkler 2024-09-18 1047 }
55936779f49612 Dave Penkler 2024-09-18 1048 e_priv->write_transfer_counter_res = res;
55936779f49612 Dave Penkler 2024-09-18 1049
55936779f49612 Dave Penkler 2024-09-18 1050 e_priv->write_transfer_counter = ioremap(e_priv->write_transfer_counter_res->start,
55936779f49612 Dave Penkler 2024-09-18 1051 resource_size(e_priv->write_transfer_counter_res));
55936779f49612 Dave Penkler 2024-09-18 1052 pr_info("gpib: write transfer counter %lx remapped to %p, length=%d\n",
55936779f49612 Dave Penkler 2024-09-18 1053 (unsigned long)e_priv->write_transfer_counter_res->start,
55936779f49612 Dave Penkler 2024-09-18 1054 e_priv->write_transfer_counter,
55936779f49612 Dave Penkler 2024-09-18 1055 (int)resource_size(e_priv->write_transfer_counter_res));
55936779f49612 Dave Penkler 2024-09-18 1056 if (!e_priv->write_transfer_counter) {
55936779f49612 Dave Penkler 2024-09-18 1057 dev_err(&fluke_gpib_pdev->dev, "Could not map I/O memory\n");
55936779f49612 Dave Penkler 2024-09-18 1058 return -ENOMEM;
55936779f49612 Dave Penkler 2024-09-18 1059 }
55936779f49612 Dave Penkler 2024-09-18 1060
55936779f49612 Dave Penkler 2024-09-18 1061 irq = platform_get_irq(fluke_gpib_pdev, 0);
55936779f49612 Dave Penkler 2024-09-18 1062 pr_info("gpib: irq %d\n", irq);
55936779f49612 Dave Penkler 2024-09-18 1063 if (irq < 0) {
55936779f49612 Dave Penkler 2024-09-18 1064 dev_err(&fluke_gpib_pdev->dev, "fluke_gpib: request for IRQ failed\n");
55936779f49612 Dave Penkler 2024-09-18 1065 return -EBUSY;
55936779f49612 Dave Penkler 2024-09-18 1066 }
55936779f49612 Dave Penkler 2024-09-18 1067 retval = request_irq(irq, fluke_gpib_interrupt, isr_flags, fluke_gpib_pdev->name, board);
55936779f49612 Dave Penkler 2024-09-18 1068 if (retval) {
55936779f49612 Dave Penkler 2024-09-18 1069 dev_err(&fluke_gpib_pdev->dev,
55936779f49612 Dave Penkler 2024-09-18 1070 "cannot register interrupt handler err=%d\n",
55936779f49612 Dave Penkler 2024-09-18 1071 retval);
55936779f49612 Dave Penkler 2024-09-18 1072 return retval;
55936779f49612 Dave Penkler 2024-09-18 1073 }
55936779f49612 Dave Penkler 2024-09-18 1074 e_priv->irq = irq;
55936779f49612 Dave Penkler 2024-09-18 1075
55936779f49612 Dave Penkler 2024-09-18 1076 dma_cap_zero(dma_cap);
55936779f49612 Dave Penkler 2024-09-18 1077 dma_cap_set(DMA_SLAVE, dma_cap);
55936779f49612 Dave Penkler 2024-09-18 1078 e_priv->dma_channel = dma_request_channel(dma_cap, gpib_dma_channel_filter, NULL);
55936779f49612 Dave Penkler 2024-09-18 1079 if (!e_priv->dma_channel) {
55936779f49612 Dave Penkler 2024-09-18 1080 pr_err("fluke_gpib: failed to allocate a dma channel.\n");
55936779f49612 Dave Penkler 2024-09-18 1081 // we don't error out here because unaccel interface will still
55936779f49612 Dave Penkler 2024-09-18 1082 // work without dma
55936779f49612 Dave Penkler 2024-09-18 1083 }
55936779f49612 Dave Penkler 2024-09-18 1084
55936779f49612 Dave Penkler 2024-09-18 1085 return fluke_init(e_priv, board, handshake_mode);
55936779f49612 Dave Penkler 2024-09-18 1086 }
55936779f49612 Dave Penkler 2024-09-18 1087
:::::: The code at line 1013 was first introduced by commit
:::::: 55936779f4961299efa99a6843c8ff3b019d3858 staging: gpib: Add Fluke cda based cards GPIB driver
:::::: TO: Dave Penkler <dpenkler@...il.com>
:::::: CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists