linux-kernel - [PATCH] hwmon: fix a NULL vs IS_ERR() check in xgene_hwmon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <tencent_370DBB5BD8EF699EC030ACA74BCB440FFA0A@qq.com>
Date: Sat,  1 Mar 2025 22:43:39 -0500
From: xinghuo.chen@...mail.com
To: jdelvare@...e.com
Cc: linux@...ck-us.net,
	linux-hwmon@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	jingfelix@...t.edu.cn,
	Xinghuo Chen <xinghuo.chen@...mail.com>
Subject: [PATCH] hwmon: fix a NULL vs IS_ERR() check in xgene_hwmon_probe()

From: Xinghuo Chen <xinghuo.chen@...mail.com>

The devm_memremap() function returns error pointers on error,
it doesn't return NULL.

Signed-off-by: Xinghuo Chen <xinghuo.chen@...mail.com>
---
 drivers/hwmon/xgene-hwmon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/xgene-hwmon.c b/drivers/hwmon/xgene-hwmon.c
index 1e3bd129a922..4fe30198bae8 100644
--- a/drivers/hwmon/xgene-hwmon.c
+++ b/drivers/hwmon/xgene-hwmon.c
@@ -706,7 +706,7 @@ static int xgene_hwmon_probe(struct platform_device *pdev)
 			goto out;
 		}
 
-		if (!ctx->pcc_comm_addr) {
+		if (IS_ERR(ctx->pcc_comm_addr)) {
 			dev_err(&pdev->dev,
 				"Failed to ioremap PCC comm region\n");
 			rc = -ENOMEM;
-- 
2.17.1