linux-kernel - Re: [PATCH] hwmon: fix a NULL vs IS_ERR() check in xgene_hwmon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fadb9614-306a-4fcd-9829-bf3e50490707@roeck-us.net>
Date: Sun, 2 Mar 2025 08:25:12 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: xinghuo.chen@...mail.com, jdelvare@...e.com
Cc: linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
 jingfelix@...t.edu.cn
Subject: Re: [PATCH] hwmon: fix a NULL vs IS_ERR() check in
 xgene_hwmon_probe()

On 3/1/25 19:43, xinghuo.chen@...mail.com wrote:
> From: Xinghuo Chen <xinghuo.chen@...mail.com>
> 
> The devm_memremap() function returns error pointers on error,
> it doesn't return NULL.
> 
> Signed-off-by: Xinghuo Chen <xinghuo.chen@...mail.com>

Fixes: c7cefce03e69 ("hwmon: (xgene) access mailbox as RAM")

> ---
>   drivers/hwmon/xgene-hwmon.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/xgene-hwmon.c b/drivers/hwmon/xgene-hwmon.c
> index 1e3bd129a922..4fe30198bae8 100644
> --- a/drivers/hwmon/xgene-hwmon.c
> +++ b/drivers/hwmon/xgene-hwmon.c
> @@ -706,7 +706,7 @@ static int xgene_hwmon_probe(struct platform_device *pdev)
>   			goto out;
>   		}
>   
> -		if (!ctx->pcc_comm_addr) {
> +		if (IS_ERR(ctx->pcc_comm_addr)) {
>   			dev_err(&pdev->dev,
>   				"Failed to ioremap PCC comm region\n");
>   			rc = -ENOMEM;

While it is correct that devm_memremap() returns an ERR_PTR() on error,
devm_ioremap() returns NULL. So this has to be IS_ERR_OR_NULL().

Guenter