linux-kernel - Re: [PATCH] drm/appletbdrm: Fix format specifier for size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h648zy3b.fsf@intel.com>
Date: Tue, 04 Mar 2025 16:09:44 +0200
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Nathan Chancellor <nathan@...nel.org>, Aun-Ali Zaidi <admin@...eit.net>,
 Aditya Garg <gargaditya08@...e.com>, Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
 Thomas Zimmermann <tzimmermann@...e.de>
Cc: Atharva Tiwari <evepolonium@...il.com>, Kerem Karabay
 <kekrby@...il.com>, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, patches@...ts.linux.dev, Nathan Chancellor
 <nathan@...nel.org>
Subject: Re: [PATCH] drm/appletbdrm: Fix format specifier for size_t variables

On Tue, 04 Mar 2025, Nathan Chancellor <nathan@...nel.org> wrote:
> When building for a 32-bit platform, there are some warnings (or errors
> with CONFIG_WERROR=y) due to an incorrect specifier for 'size_t'
> variables, which is typedef'd as 'unsigned int' for these architectures:
>
>   drivers/gpu/drm/tiny/appletbdrm.c:171:17: error: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Werror,-Wformat]
>     170 |                 drm_err(drm, "Actual size (%d) doesn't match expected size (%lu)\n",
>         |                                                                             ~~~
>         |                                                                             %zu
>     171 |                         actual_size, size);
>         |                                      ^~~~
>   ...
>   drivers/gpu/drm/tiny/appletbdrm.c:212:17: error: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Werror,-Wformat]
>     211 |                 drm_err(drm, "Actual size (%d) doesn't match expected size (%lu)\n",
>         |                                                                             ~~~
>         |                                                                             %zu
>     212 |                         actual_size, size);
>         |                                      ^~~~
>
> Use '%zu' as suggested, clearing up the warnings.
>
> Fixes: 0670c2f56e45 ("drm/tiny: add driver for Apple Touch Bars in x86 Macs")
> Signed-off-by: Nathan Chancellor <nathan@...nel.org>

Just sent an identical patch [1]. :)

You have a better commit message, let's go with this. With Aditya's ack
from the other thread,

Reviewed-by: Jani Nikula <jani.nikula@...el.com>
Acked-by: Aditya Garg <gargaditya08@...e.com>

[1] https://lore.kernel.org/r/20250304135456.429407-1-jani.nikula@intel.com

> ---
>  drivers/gpu/drm/tiny/appletbdrm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/tiny/appletbdrm.c b/drivers/gpu/drm/tiny/appletbdrm.c
> index f5d177e234e4..394c8f9bd41a 100644
> --- a/drivers/gpu/drm/tiny/appletbdrm.c
> +++ b/drivers/gpu/drm/tiny/appletbdrm.c
> @@ -167,7 +167,7 @@ static int appletbdrm_send_request(struct appletbdrm_device *adev,
>  	}
>  
>  	if (actual_size != size) {
> -		drm_err(drm, "Actual size (%d) doesn't match expected size (%lu)\n",
> +		drm_err(drm, "Actual size (%d) doesn't match expected size (%zu)\n",
>  			actual_size, size);
>  		return -EIO;
>  	}
> @@ -208,7 +208,7 @@ static int appletbdrm_read_response(struct appletbdrm_device *adev,
>  	}
>  
>  	if (actual_size != size) {
> -		drm_err(drm, "Actual size (%d) doesn't match expected size (%lu)\n",
> +		drm_err(drm, "Actual size (%d) doesn't match expected size (%zu)\n",
>  			actual_size, size);
>  		return -EBADMSG;
>  	}
>
> ---
> base-commit: 95a5c9d197bb22a506913acb330a926d4e51aa95
> change-id: 20250304-appletbdrm-fix-size_t-specifier-d3c547522379
>
> Best regards,

-- 
Jani Nikula, Intel