linux-kernel - Re: [PATCH] drm/appletbdrm: Fix format specifier for size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PN3PR01MB959766B5334E2D3B953ADE0EB8C82@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>
Date: Tue, 4 Mar 2025 14:20:06 +0000
From: Aditya Garg <gargaditya08@...e.com>
To: Nathan Chancellor <nathan@...nel.org>
CC: Aun-Ali Zaidi <admin@...eit.net>, Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>, Atharva Tiwari
	<evepolonium@...il.com>, Kerem Karabay <kekrby@...il.com>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"patches@...ts.linux.dev" <patches@...ts.linux.dev>, Nathan Chancellor
	<nathan@...nel.org>
Subject: Re: [PATCH] drm/appletbdrm: Fix format specifier for size_t variables



> On 4 Mar 2025, at 6:49 PM, Nathan Chancellor <nathan@...nel.org> wrote:
> 
> When building for a 32-bit platform, there are some warnings (or errors
> with CONFIG_WERROR=y) due to an incorrect specifier for 'size_t'
> variables, which is typedef'd as 'unsigned int' for these architectures:
> 
>  drivers/gpu/drm/tiny/appletbdrm.c:171:17: error: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Werror,-Wformat]
>    170 |                 drm_err(drm, "Actual size (%d) doesn't match expected size (%lu)\n",
>        |                                                                             ~~~
>        |                                                                             %zu
>    171 |                         actual_size, size);
>        |                                      ^~~~
>  ...
>  drivers/gpu/drm/tiny/appletbdrm.c:212:17: error: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Werror,-Wformat]
>    211 |                 drm_err(drm, "Actual size (%d) doesn't match expected size (%lu)\n",
>        |                                                                             ~~~
>        |                                                                             %zu
>    212 |                         actual_size, size);
>        |                                      ^~~~
> 
> Use '%zu' as suggested, clearing up the warnings.
> 
> Fixes: 0670c2f56e45 ("drm/tiny: add driver for Apple Touch Bars in x86 Macs")
> Signed-off-by: Nathan Chancellor <nathan@...nel.org>
> ---
> drivers/gpu/drm/tiny/appletbdrm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

This went into my spam for some reason, but looks like Jani already informed you about my Ack :)