linux-kernel - Re: [PATCH] usb: quirks: Add DELAY_INIT and NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025030339-morbidly-relax-80c0@gregkh>
Date: Mon, 3 Mar 2025 10:16:46 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Miao Li <limiao870622@....com>
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Miao Li <limiao@...inos.cn>
Subject: Re: [PATCH] usb: quirks: Add DELAY_INIT and NO_LPM for Prolific
 PL2303 Serial Port

On Mon, Mar 03, 2025 at 03:00:47PM +0800, Miao Li wrote:
> From: Miao Li <limiao@...inos.cn>
> 
> When used on Huawei hisi platforms, Prolific PL2303 Serial Port which
> the VID:PID is in 067b:2731 might fail to enumerate at boot time and
> doesn't work well with LPM enabled, combination quirks:
> USB_QUIRK_DELAY_INIT + USB_QUIRK_NO_LPM
> fixed the problems.
> 
> Signed-off-by: Miao Li <limiao@...inos.cn>
> ---
>  drivers/usb/core/quirks.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index dfcfc142bd5e..8aca5518e003 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -341,6 +341,10 @@ static const struct usb_device_id usb_quirk_list[] = {
>  	{ USB_DEVICE(0x0638, 0x0a13), .driver_info =
>  	  USB_QUIRK_STRING_FETCH_255 },
>  
> +	/* Prolific PL2303 Serial Port */
> +	{ USB_DEVICE(0x067b, 0x2731), .driver_info = USB_QUIRK_DELAY_INIT |
> +	  USB_QUIRK_NO_LPM },

But this is not the device id for a pl2303 device (or at least one that
Linux supports), so how was this tested?

And why would this device suddenly stop working?  This chipset has been
working with Linux for decades now, what is new about this device that
requires this change?

thanks,

greg k-h