linux-kernel - Re: mtd: rawnand: tegra: Simplify maximum determination in tegra_nand_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h64a9y04.fsf@bootlin.com>
Date: Mon, 03 Mar 2025 12:03:55 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Markus Elfring <Markus.Elfring@....de>
Cc: linux-tegra@...r.kernel.org,  linux-mtd@...ts.infradead.org,  Jonathan
 Hunter <jonathanh@...dia.com>,  Lucas Stach <dev@...xeye.de>,  Richard
 Weinberger <richard@....at>,  Stefan Agner <stefan@...er.ch>,  Thierry
 Reding <thierry.reding@...il.com>,  Vignesh Raghavendra <vigneshr@...com>,
  LKML <linux-kernel@...r.kernel.org>,  kernel-janitors@...r.kernel.org,
  Qasim Ijaz <qasdev00@...il.com>,  Natalie Vock <natalie.vock@....de>
Subject: Re: mtd: rawnand: tegra: Simplify maximum determination in
 tegra_nand_setup_timing()

On 03/03/2025 at 11:55:49 +01, Markus Elfring <Markus.Elfring@....de> wrote:

>> I am sorry, I do not see what gets simplified. max(max(a,b),max(c,d))
>> looks simpler than max3(a,b,max(c,d)).
>
> You would eventually like to express that a maximum should be determined
> from three (or even four?) values.

If there was a max4(), why not, but in this case I don't see the point.

> https://elixir.bootlin.com/linux/v6.14-rc4/source/include/linux/minmax.h#L147
>
>
>>                                        Does it bring something in terms
>> of optimization?
> Corresponding effects depend on various factors, don't they?

Ok, so I'll assume the answer to my question is "no".

Thanks,
Miquèl