linux-kernel - Re: [PATCH v2 1/2] dt-bindings: power: supply: Document Maxim MAX8971 charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a091f085-a7f0-4aaa-997d-cd478764c18a@kernel.org>
Date: Mon, 3 Mar 2025 09:23:38 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Svyatoslav Ryhel <clamor95@...il.com>
Cc: Sebastian Reichel <sre@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: power: supply: Document Maxim MAX8971
 charger

On 03/03/2025 09:13, Svyatoslav Ryhel wrote:
> пн, 3 бер. 2025 р. о 09:52 Krzysztof Kozlowski <krzk@...nel.org> пише:
>>
>> On 27/02/2025 12:03, Svyatoslav Ryhel wrote:
>>> чт, 27 лют. 2025 р. о 12:45 Krzysztof Kozlowski <krzk@...nel.org> пише:
>>>>
>>>> On Wed, Feb 26, 2025 at 11:36:59AM +0200, Svyatoslav Ryhel wrote:
>>>>> +  maxim,fcharge-current-limit-microamp:
>>>>> +    description:
>>>>> +      Fast-Charge current limit
>>>>> +    minimum: 250000
>>>>> +    default: 500000
>>>>> +    maximum: 1550000
>>>>> +
>>>>> +  maxim,fcharge-timer-hours:
>>>>> +    description:
>>>>> +      Fast-Charge timer in hours. Setting this value 3 and lower or 11 and higher
>>>>> +      will disable Fast-Charge timer.
>>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>>> +    default: 5
>>>>
>>>> You still did not answer why this is board specific. This was rejected
>>>> in the past because of that reason and nothing here changed. Nothing

Where are the arguments to existing/previous decisions?

>>>> will change without detailed explanation, so use other interfaces if you

Again, where is detailed explanation why time is determined per board,
unlike previously agreed that it is not?

>>>> need user-space to configure it (see other drivers, e.g. maxim)




>>>>
>>>
>>> Btw, I have used this awesome example you have provided. Take a look
>>
>> Where did I provide this example?
>>
> 
> Its presence in the docs is an example on its no? You have explicitly
> told to check other maxim devices, I did so, they all have similar set
> of convifurations.

Choose rather later or latest, not 12 YO, binding as an example.

> 
>>>
>>> https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/power/supply/maxim,max77693.yaml?h=v6.14-rc4
>>
>> I opened it and I do not see anything about time. Please point to
>> specific line.
>>
>> But regardless, how did I propose to use 12 year old binding? Where did
>> I suggest that one?
>>
>>>
>>> Oh, I wonder why it uses so much values which duplicate battery? I
>>> know, it lacks battery, I assume that is why?
>>
>> No. You added to DT something which is not a hardware property, but
>> user-space choice or policy.
>>
> 
> It is NOT a user-space choice or policy!
Previous discussions on the lists - since you mention 12 year old
binding, so also discussions 12 years ago - determined that they are
closer to them than board configuration.

I already said - this was rejected in the past - so now I am repeating
myself.

You did not bring any arguments just keep repeating "no", so I suggest
reading previous discussions and coming with arguments against them.

Best regards,
Krzysztof