linux-kernel - Re: [PATCH RESEND v1] HID: Intel-thc-hid: Intel-quickspi: Correct device state after S4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96qpo784-8r1o-sor7-p42q-q06n1p389913@xreary.bet>
Date: Tue, 4 Mar 2025 21:54:12 +0100 (CET)
From: Jiri Kosina <jikos@...nel.org>
To: Even Xu <even.xu@...el.com>
cc: bentiss@...nel.org, srinivas.pandruvada@...ux.intel.com, 
    mpearson-lenovo@...ebb.ca, linux-input@...r.kernel.org, 
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND v1] HID: Intel-thc-hid: Intel-quickspi: Correct
 device state after S4

On Tue, 4 Mar 2025, Even Xu wrote:

> During S4 retore flow, quickspi device was resetted by driver and state
> was changed to RESETTED. It is needed to be change to ENABLED state
> after S4 re-initialization finished, otherwise, device will run in wrong
> state and HID input data will be dropped.

Um, RESETTED, really?

In the code the flag is called QUICKI2C_RESETED, but that seems to be 
gramatically incorrect as well, right?

I'll now apply this as-is because the code is already in, but perhaps 
renaming the flag to QUICKI2C_RESET would be in order.

Thanks,

-- 
Jiri Kosina
SUSE Labs