linux-kernel - RE: [PATCH RESEND v1] HID: Intel-thc-hid: Intel-quickspi: Correct device state after S4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA1PR11MB6098ECF413F5F4E8FD120B4EF4CB2@IA1PR11MB6098.namprd11.prod.outlook.com>
Date: Wed, 5 Mar 2025 00:59:01 +0000
From: "Xu, Even" <even.xu@...el.com>
To: Jiri Kosina <jikos@...nel.org>
CC: "bentiss@...nel.org" <bentiss@...nel.org>,
	"srinivas.pandruvada@...ux.intel.com" <srinivas.pandruvada@...ux.intel.com>,
	"mpearson-lenovo@...ebb.ca" <mpearson-lenovo@...ebb.ca>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH RESEND v1] HID: Intel-thc-hid: Intel-quickspi: Correct
 device state after S4



> -----Original Message-----
> From: Jiri Kosina <jikos@...nel.org>
> Sent: Wednesday, March 5, 2025 4:54 AM
> To: Xu, Even <even.xu@...el.com>
> Cc: bentiss@...nel.org; srinivas.pandruvada@...ux.intel.com; mpearson-
> lenovo@...ebb.ca; linux-input@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH RESEND v1] HID: Intel-thc-hid: Intel-quickspi: Correct device
> state after S4
> 
> On Tue, 4 Mar 2025, Even Xu wrote:
> 
> > During S4 retore flow, quickspi device was resetted by driver and
> > state was changed to RESETTED. It is needed to be change to ENABLED
> > state after S4 re-initialization finished, otherwise, device will run
> > in wrong state and HID input data will be dropped.
> 
> Um, RESETTED, really?

Sorry, it's my bad, it should be RESET.

> 
> In the code the flag is called QUICKI2C_RESETED, but that seems to be
> gramatically incorrect as well, right?

Yes, you are right, let me create a patch to correct it.

> 
> I'll now apply this as-is because the code is already in, but perhaps renaming the
> flag to QUICKI2C_RESET would be in order.

Current patch is still needed, quickspi device init flow is: init -> resetting -> reset -> enabled.
Exiting code in pm restore() callback takes reset operation and puts device into reset state, but forgets
move to enabled state after init flow is done.

Thanks for your suggestion! Let me refine the patch in V2.

Best Regards,
Even Xu 

> 
> Thanks,
> 
> --
> Jiri Kosina
> SUSE Labs