linux-kernel - Re: [PATCH v2 2/7] dt-bindings: clock: brcm,kona-ccu: Add BCM281xx bus clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250304-fat-nebulous-meerkat-008f04@krzk-bin>
Date: Tue, 4 Mar 2025 08:35:16 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Artur Weber <aweber.kernel@...il.com>
Cc: Michael Turquette <mturquette@...libre.com>, 
	Stephen Boyd <sboyd@...nel.org>, Florian Fainelli <florian.fainelli@...adcom.com>, 
	Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Alex Elder <elder@...nel.org>, Stanislav Jakubek <stano.jakubek@...il.com>, 
	linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, 
	~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH v2 2/7] dt-bindings: clock: brcm,kona-ccu: Add BCM281xx
 bus clocks

On Mon, Mar 03, 2025 at 09:27:50PM +0100, Artur Weber wrote:
>    - if:
>        properties:
>          compatible:
> diff --git a/include/dt-bindings/clock/bcm281xx.h b/include/dt-bindings/clock/bcm281xx.h
> index d74ca42112e79746c513f6861a89628ee03f0f79..15449f998eb7a5a191fd847b689cfbe60b27c541 100644
> --- a/include/dt-bindings/clock/bcm281xx.h
> +++ b/include/dt-bindings/clock/bcm281xx.h
> @@ -34,7 +34,9 @@
>  #define BCM281XX_AON_CCU_HUB_TIMER		0
>  #define BCM281XX_AON_CCU_PMU_BSC		1
>  #define BCM281XX_AON_CCU_PMU_BSC_VAR		2
> -#define BCM281XX_AON_CCU_CLOCK_COUNT		3

You cannot change defines, it is an ABI. Unless it is not an ABI... so
just drop all these counts in separate patch, just like we were doing
for other platforms.

Best regards,
Krzysztof