linux-kernel - Re: [PATCH 1/9] drivers/perf: hisi: Extend struct hisi_pmu_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250304172102.00006e54@huawei.com>
Date: Tue, 4 Mar 2025 17:21:02 +0800
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Yicong Yang <yangyicong@...wei.com>
CC: Will Deacon <will@...nel.org>, <yangyicong@...ilicon.com>,
	<mark.rutland@....com>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <prime.zeng@...ilicon.com>,
	<linuxarm@...wei.com>, <wangyushan12@...wei.com>
Subject: Re: [PATCH 1/9] drivers/perf: hisi: Extend struct hisi_pmu_dev_info

On Mon, 3 Mar 2025 22:43:35 +0800
Yicong Yang <yangyicong@...wei.com> wrote:

> On 2025/3/1 14:23, Will Deacon wrote:
> > On Tue, Feb 18, 2025 at 05:19:52PM +0800, Yicong Yang wrote:  
> >> From: Junhao He <hejunhao3@...wei.com>
> >>
> >> The counter bits and event range may differ from versions of a
> >> certain uncore PMU. Make this device specific information into
> >> struct hisi_pmu_dev_info. This will help to simplify the
> >> initialization process by using a list of struct hisi_pmu_dev_info
> >> rather than checking the version.
> >>
> >> Signed-off-by: Junhao He <hejunhao3@...wei.com>
> >> Signed-off-by: Yicong Yang <yangyicong@...ilicon.com>
> >> ---
> >>  drivers/perf/hisilicon/hisi_uncore_pmu.h | 2 ++
> >>  1 file changed, 2 insertions(+)
> >>
> >> diff --git a/drivers/perf/hisilicon/hisi_uncore_pmu.h b/drivers/perf/hisilicon/hisi_uncore_pmu.h
> >> index f4fed2544877..777675838b80 100644
> >> --- a/drivers/perf/hisilicon/hisi_uncore_pmu.h
> >> +++ b/drivers/perf/hisilicon/hisi_uncore_pmu.h
> >> @@ -72,6 +72,8 @@ struct hisi_uncore_ops {
> >>  struct hisi_pmu_dev_info {
> >>  	const char *name;
> >>  	const struct attribute_group **attr_groups;
> >> +	u32 counter_bits;
> >> +	u32 check_event;
This name is a little confusing.  Maybe nr_events or similar?


> >>  	void *private;
> >>  };  
> > 
> > This doesn't really do anything on its own; please just fold it into the
> > patch where the new fields are used.
> >   
> 
> sure, will make this into the following patch.
> 
> Thanks.
>