linux-kernel - Re: [PATCH 2/9] drivers/perf: hisi: Simplify the probe process for each DDRC version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250304172649.0000189c@huawei.com>
Date: Tue, 4 Mar 2025 17:26:49 +0800
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Yicong Yang <yangyicong@...wei.com>
CC: <will@...nel.org>, <mark.rutland@....com>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
	<prime.zeng@...ilicon.com>, <linuxarm@...wei.com>,
	<yangyicong@...ilicon.com>, <wangyushan12@...wei.com>
Subject: Re: [PATCH 2/9] drivers/perf: hisi: Simplify the probe process for
 each DDRC version

On Tue, 18 Feb 2025 17:19:53 +0800
Yicong Yang <yangyicong@...wei.com> wrote:

> From: Junhao He <hejunhao3@...wei.com>
> 
> Version 1 and 2 of DDRC PMU also use different HID. Make use of
> struct acpi_device_id::driver_data for version specific information
> rather than judge the version register. This will help to
> simplify the probe process and also a bit easier for extension.
> 
> Signed-off-by: Junhao He <hejunhao3@...wei.com>
> Signed-off-by: Yicong Yang <yangyicong@...ilicon.com>
Looks good to me. Looking at this I can see the check_reg naming
is an existing thing so maybe leave that alone for now and consider
renaming as a future improvement in readability.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>