linux-kernel - Re: [PATCH v2 5/6] sysctl/infiniband: Fixes infiniband sysctl bounds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <i4x736hwah7vc7mjjooxyeo3t73wzcm365mah3qganrs6x6l2d@khb2a6uggrop>
Date: Wed, 5 Mar 2025 15:43:47 +0100
From: Joel Granados <joel.granados@...nel.org>
To: Leon Romanovsky <leon@...nel.org>
Cc: nicolas.bouchinet@...p-os.org, linux-kernel@...r.kernel.org, 
	linux-rdma@...r.kernel.org, linux-scsi@...r.kernel.org, codalist@...a.cs.cmu.edu, 
	linux-nfs@...r.kernel.org, Nicolas Bouchinet <nicolas.bouchinet@....gouv.fr>, 
	Joel Granados <j.granados@...sung.com>, Clemens Ladisch <clemens@...isch.de>, 
	Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Jason Gunthorpe <jgg@...pe.ca>, "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>, 
	"Martin K. Petersen" <martin.petersen@...cle.com>, Jan Harkes <jaharkes@...cmu.edu>, 
	Chuck Lever <chuck.lever@...cle.com>, Jeff Layton <jlayton@...nel.org>, Neil Brown <neilb@...e.de>, 
	Olga Kornievskaia <okorniev@...hat.com>, Dai Ngo <Dai.Ngo@...cle.com>, Tom Talpey <tom@...pey.com>, 
	Trond Myklebust <trondmy@...nel.org>, Anna Schumaker <anna@...nel.org>, 
	Bart Van Assche <bvanassche@....org>, Zhu Yanjun <yanjun.zhu@...ux.dev>, 
	Al Viro <viro@...iv.linux.org.uk>, Christian Brauner <brauner@...nel.org>
Subject: Re: [PATCH v2 5/6] sysctl/infiniband: Fixes infiniband sysctl bounds

On Mon, Mar 03, 2025 at 08:53:09PM +0200, Leon Romanovsky wrote:
> On Mon, Mar 03, 2025 at 02:57:29PM +0100, Joel Granados wrote:
> > On Mon, Feb 24, 2025 at 03:41:05PM +0200, Leon Romanovsky wrote:
> > > On Mon, Feb 24, 2025 at 10:58:20AM +0100, nicolas.bouchinet@...p-os.org wrote:
> > > > From: Nicolas Bouchinet <nicolas.bouchinet@....gouv.fr>
> > > > 
> > > > Bound infiniband iwcm and ucma sysctl writings between SYSCTL_ZERO
> > > > and SYSCTL_INT_MAX.
> > > > 
> > > > The proc_handler has thus been updated to proc_dointvec_minmax.
> > > > 
> > > > Signed-off-by: Nicolas Bouchinet <nicolas.bouchinet@....gouv.fr>
> > > > ---
> > > >  drivers/infiniband/core/iwcm.c | 4 +++-
> > > >  drivers/infiniband/core/ucma.c | 4 +++-
> > > >  2 files changed, 6 insertions(+), 2 deletions(-)
> > > > 
> > > 
> > > Acked-by: Leon Romanovsky <leon@...nel.org>
> > > 
> > > How do you want to proceed from here? Should I take to RDMA repository?
> > > 
> > > Thanks
> > It would be great if we push this through RDMA. Here are a few comments:
> > 1. Having the upper bound be SYSCTL_INT_MAX is not necessary (as it is
> >    silently capped by proc_dointvec_minmax, but it is good to have as it
> >    gives understanding on what the spread of the values are.
> > 
> > 2. Having the lower bound capped by SYSCTL_ZERO is needed as it will
> >    prevent ppl trying to assing negative values to the unsigned integers
> > 
> > Please let me know if you will push this through RDMA, so I know to
> > remove it from sysctl.
> 
> Applied to RDMA tree.
> https://web.git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?h=wip/leon-for-next&id=f33cd9b3fd03a791296ab37550ffd26213a90c4e
Perfect. Thx.

@Nicolas: pls take this one out of your next version as it is
already on its way upstrea.

Best
> 
> > 
> > Best
> > 
> > Reviewed-by: Joel Granados <joel.granados@...nel.org>
> 
> Thanks
> 
> > 
> > -- 
> > 
> > Joel Granados

-- 

Joel Granados