linux-kernel - Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAODwPW_3BCfTcTu=K+6Q3PMe8DtWTiKFHC6+HO2q+cTqs=EPAA@mail.gmail.com>
Date: Wed, 5 Mar 2025 14:50:20 -0800
From: Julius Werner <jwerner@...omium.org>
To: George Cherian <george.cherian@...vell.com>
Cc: linux@...ck-us.net, wim@...ux-watchdog.org, jwerner@...omium.org, 
	evanbenn@...omium.org, kabel@...nel.org, krzk@...nel.org, 
	mazziesaccount@...il.com, thomas.richard@...tlin.com, lma@...omium.org, 
	bleung@...omium.org, support.opensource@...semi.com, shawnguo@...nel.org, 
	s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com, 
	andy@...nel.org, paul@...pouillou.net, alexander.usyskin@...el.com, 
	andreas.werner@....de, daniel@...ngy.jp, romain.perier@...il.com, 
	avifishman70@...il.com, tmaimon77@...il.com, tali.perry1@...il.com, 
	venture@...gle.com, yuenn@...gle.com, benjaminfair@...gle.com, 
	maddy@...ux.ibm.com, mpe@...erman.id.au, npiggin@...il.com, 
	christophe.leroy@...roup.eu, naveen@...nel.org, mwalle@...nel.org, 
	xingyu.wu@...rfivetech.com, ziv.xu@...rfivetech.com, 
	hayashi.kunihiko@...ionext.com, mhiramat@...nel.org, 
	linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, chrome-platform@...ts.linux.dev, 
	imx@...ts.linux.dev, linux-mips@...r.kernel.org, openbmc@...ts.ozlabs.org, 
	linuxppc-dev@...ts.ozlabs.org, patches@...nsource.cirrus.com
Subject: Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP

>  static const struct watchdog_ops adv_ec_wdt_ops = {
> diff --git a/drivers/watchdog/arm_smc_wdt.c b/drivers/watchdog/arm_smc_wdt.c
> index 8f3d0c3a005f..794cf0086912 100644
> --- a/drivers/watchdog/arm_smc_wdt.c
> +++ b/drivers/watchdog/arm_smc_wdt.c
> @@ -90,7 +90,8 @@ static const struct watchdog_info smcwd_info = {
>         .identity       = DRV_NAME,
>         .options        = WDIOF_SETTIMEOUT |
>                           WDIOF_KEEPALIVEPING |
> -                         WDIOF_MAGICCLOSE,
> +                         WDIOF_MAGICCLOSE |
> +                         WDIOF_STOP_MAYSLEEP,
>  };

I don't think this driver can sleep, unless I'm missing something?
`arm_smccc_smc()` does a synchronous call into firmware that always
returns back to the caller.